misc - commented out io.ReadFull and replaced it with random bytes ge…

…nerated off the faker struct

misc.go

@@ -2,7 +2,6 @@ package gofakeit
 
 import (
 	"encoding/hex"
-	"io"
 	"math/rand"
 	"reflect"
 
@@ -22,13 +21,20 @@ func boolFunc(r *rand.Rand) bool { return randIntRange(r, 0, 1) == 1 }
 func UUID() string { return uuid(globalFaker.Rand) }
 
 // UUID (version 4) will generate a random unique identifier based upon random numbers
-// Format: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
+// Format: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx 8-4-4-4-12
 func (f *Faker) UUID() string { return uuid(f.Rand) }
 
 func uuid(r *rand.Rand) string {
 	version := byte(4)
 	uuid := make([]byte, 16)
-	io.ReadFull(r, uuid[:])
+
+	// Commented out due to io.ReadFull not being race condition safe
+	// io.ReadFull(r, uuid[:])
+
+	// Read 16 random bytes
+	for i := 0; i < 16; i++ {
+		uuid[i] = byte(r.Intn(256))
+	}
 
 	// Set version
 	uuid[6] = (uuid[6] & 0x0f) | (version << 4)

misc_test.go

@@ -49,20 +49,28 @@ func TestUUID(t *testing.T) {
 	id := UUID()
 
 	if len(id) != 36 {
+		t.Error(id)
 		t.Error("unique length does not equal requested length")
 	}
+
+	// Checking for race conditions, need to run --race
+	for i := 0; i < 10000; i++ {
+		go func() {
+			_ = UUID()
+		}()
+	}
 }
 
 func ExampleUUID() {
 	Seed(11)
 	fmt.Println(UUID())
-	// Output: 590c1440-9888-45b0-bd51-a817ee07c3f2
+	// Output: 98173564-6619-4557-888e-65b16bb5def5
 }
 
 func ExampleFaker_UUID() {
 	f := New(11)
 	fmt.Println(f.UUID())
-	// Output: 590c1440-9888-45b0-bd51-a817ee07c3f2
+	// Output: 98173564-6619-4557-888e-65b16bb5def5
 }
 
 func BenchmarkUUID(b *testing.B) {