Optimize performances of minOf/maxOf methods.

brick · Sep 14, 2023 · 1d93d18 · 1d93d18
1 parent c7c2107
commit 1d93d18
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/src/LocalDate.php b/src/LocalDate.php
@@ -14,6 +14,7 @@
 use DateTimeInterface;
 use JsonSerializable;
 
+use function array_shift;
 use function intdiv;
 use function min;
 use function sprintf;
@@ -249,7 +250,7 @@ public static function minOf(LocalDate ...$dates): LocalDate
             throw new DateTimeException(__METHOD__ . ' does not accept less than 1 parameter.');
         }
 
-        $min = LocalDate::max();
+        $min = array_shift($dates);
 
         foreach ($dates as $date) {
             if ($date->isBefore($min)) {
@@ -275,7 +276,7 @@ public static function maxOf(LocalDate ...$dates): LocalDate
             throw new DateTimeException(__METHOD__ . ' does not accept less than 1 parameter.');
         }
 
-        $max = LocalDate::min();
+        $max = array_shift($dates);
 
         foreach ($dates as $date) {
             if ($date->isAfter($max)) {

diff --git a/src/LocalDateTime.php b/src/LocalDateTime.php
@@ -14,6 +14,7 @@
 use DateTimeInterface;
 use JsonSerializable;
 
+use function array_shift;
 use function intdiv;
 
 /**
@@ -134,7 +135,7 @@ public static function minOf(LocalDateTime ...$times): LocalDateTime
             throw new DateTimeException(__METHOD__ . ' does not accept less than 1 parameter.');
         }
 
-        $min = LocalDateTime::max();
+        $min = array_shift($times);
 
         foreach ($times as $time) {
             if ($time->isBefore($min)) {
@@ -160,7 +161,7 @@ public static function maxOf(LocalDateTime ...$times): LocalDateTime
             throw new DateTimeException(__METHOD__ . ' does not accept less than 1 parameter.');
         }
 
-        $max = LocalDateTime::min();
+        $max = array_shift($times);
 
         foreach ($times as $time) {
             if ($time->isAfter($max)) {

diff --git a/src/LocalTime.php b/src/LocalTime.php
@@ -17,6 +17,7 @@
 use DateTimeInterface;
 use JsonSerializable;
 
+use function array_shift;
 use function intdiv;
 use function rtrim;
 use function sprintf;
@@ -214,7 +215,7 @@ public static function minOf(LocalTime ...$times): LocalTime
             throw new DateTimeException(__METHOD__ . ' does not accept less than 1 parameter.');
         }
 
-        $min = LocalTime::max();
+        $min = array_shift($times);
 
         foreach ($times as $time) {
             if ($time->isBefore($min)) {
@@ -240,7 +241,7 @@ public static function maxOf(LocalTime ...$times): LocalTime
             throw new DateTimeException(__METHOD__ . ' does not accept less than 1 parameter.');
         }
 
-        $max = LocalTime::min();
+        $max = array_shift($times);
 
         foreach ($times as $time) {
             if ($time->isAfter($max)) {