min() and max() now use variadics

brick · May 22, 2015 · 9ab6358 · 9ab6358
1 parent d246c7b
commit 9ab6358
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 20 deletions.
diff --git a/src/BigDecimal.php b/src/BigDecimal.php
@@ -138,13 +138,13 @@ public static function zero()
     /**
      * Returns the minimum of the given values.
      *
-     * @param array<Decimal|number|string> An array of decimals to return the minimum value of.
+     * @param BigDecimal|number|string ...$values The numbers to compare.
      *
-     * @return \Brick\Math\BigDecimal The minimum value.
+     * @return BigDecimal The minimum value.
      *
      * @throws \InvalidArgumentException If no values are given, or an invalid value is given.
      */
-    public static function min(array $values)
+    public static function min(...$values)
     {
         $min = null;
 
@@ -165,13 +165,13 @@ public static function min(array $values)
     /**
      * Returns the maximum of the given values.
      *
-     * @param array<Decimal|number|string> An array of decimals to return the maximum value of.
+     * @param BigDecimal|number|string ...$values The numbers to compare.
      *
-     * @return \Brick\Math\BigDecimal The maximum value.
+     * @return BigDecimal The maximum value.
      *
      * @throws \InvalidArgumentException If no values are given, or an invalid value is given.
      */
-    public static function max(array $values)
+    public static function max(...$values)
     {
         $max = null;
 

diff --git a/src/BigInteger.php b/src/BigInteger.php
@@ -162,13 +162,13 @@ public static function zero()
     /**
      * Returns the minimum of the given values.
      *
-     * @param array<BigInteger|integer|string> An array of integers to return the minimum value of.
+     * @param BigInteger|integer|string ...$values The numbers to compare.
      *
-     * @return \Brick\Math\BigInteger The minimum value.
+     * @return BigInteger The minimum value.
      *
      * @throws \InvalidArgumentException If no values are given, or an invalid value is given.
      */
-    public static function min(array $values)
+    public static function min(...$values)
     {
         $min = null;
 
@@ -189,13 +189,13 @@ public static function min(array $values)
     /**
      * Returns the maximum of the given values.
      *
-     * @param array<BigInteger|integer|string> An array of integers to return the maximum value of.
+     * @param BigInteger|integer|string ...$values The numbers to compare.
      *
-     * @return \Brick\Math\BigInteger The maximum value.
+     * @return BigInteger The maximum value.
      *
      * @throws \InvalidArgumentException If no values are given, or an invalid value is given.
      */
-    public static function max(array $values)
+    public static function max(...$values)
     {
         $max = null;
 

diff --git a/tests/BigDecimalTest.php b/tests/BigDecimalTest.php
@@ -258,7 +258,7 @@ public function testZero()
      */
     public function testMin(array $values, $index)
     {
-        $this->assertTrue(BigDecimal::min($values)->isEqualTo($values[$index]));
+        $this->assertTrue(BigDecimal::min(...$values)->isEqualTo($values[$index]));
     }
 
     /**
@@ -287,7 +287,7 @@ public function providerMin()
      */
     public function testMinOfZeroValuesThrowsException()
     {
-        BigDecimal::min([]);
+        BigDecimal::min();
     }
 
     /**
@@ -298,7 +298,7 @@ public function testMinOfZeroValuesThrowsException()
      */
     public function testMax(array $values, $index)
     {
-        $this->assertTrue(BigDecimal::max($values)->isEqualTo($values[$index]));
+        $this->assertTrue(BigDecimal::max(...$values)->isEqualTo($values[$index]));
     }
 
     /**
@@ -331,7 +331,7 @@ public function providerMax()
      */
     public function testMaxOfZeroValuesThrowsException()
     {
-        BigDecimal::max([]);
+        BigDecimal::max();
     }
 
     /**

diff --git a/tests/BigIntegerTest.php b/tests/BigIntegerTest.php
@@ -321,7 +321,7 @@ public function testZero()
      */
     public function testMin(array $values, $index)
     {
-        $this->assertTrue(BigInteger::min($values)->isEqualTo($values[$index]));
+        $this->assertTrue(BigInteger::min(...$values)->isEqualTo($values[$index]));
     }
 
     /**
@@ -345,7 +345,7 @@ public function providerMin()
      */
     public function testMinOfZeroValuesThrowsException()
     {
-        BigInteger::min([]);
+        BigInteger::min();
     }
 
     /**
@@ -356,7 +356,7 @@ public function testMinOfZeroValuesThrowsException()
      */
     public function testMax(array $values, $index)
     {
-        $this->assertTrue(BigInteger::max($values)->isEqualTo($values[$index]));
+        $this->assertTrue(BigInteger::max(...$values)->isEqualTo($values[$index]));
     }
 
     /**
@@ -381,7 +381,7 @@ public function providerMax()
      */
     public function testMaxOfZeroValuesThrowsException()
     {
-        BigInteger::max([]);
+        BigInteger::max();
     }
 
     /**