Fix issue with Calculator::divQR() when bcscale() is non-zero

Fixes #55.
brick · Jan 20, 2021 · a1c7e0e · a1c7e0e
1 parent a49cf5d
commit a1c7e0e
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/src/Internal/Calculator/BcMathCalculator.php b/src/Internal/Calculator/BcMathCalculator.php
@@ -67,7 +67,12 @@ public function divR(string $a, string $b) : string
     public function divQR(string $a, string $b) : array
     {
         $q = \bcdiv($a, $b, 0);
-        $r = \bcmod($a, $b);
+
+        if (version_compare(PHP_VERSION, '7.2') >= 0) {
+            $r = \bcmod($a, $b, 0);
+        } else {
+            $r = \bcmod($a, $b);
+        }
 
         assert($q !== null);
         assert($r !== null);

diff --git a/tests/BigDecimalTest.php b/tests/BigDecimalTest.php
@@ -10,6 +10,7 @@
 use Brick\Math\Exception\NegativeNumberException;
 use Brick\Math\Exception\NumberFormatException;
 use Brick\Math\Exception\RoundingNecessaryException;
+use Brick\Math\Internal\Calculator;
 use Brick\Math\RoundingMode;
 
 /**
@@ -847,6 +848,22 @@ public function testExactlyDividedByZero() : void
         BigDecimal::of(1)->exactlyDividedBy(0);
     }
 
+    public function testExactlyDividedByWithNonZeroBcMathDefaultScale(): void
+    {
+        if (! Calculator::get() instanceof Calculator\BcMathCalculator) {
+            self::markTestSkipped('This test targets the BCMath calculator only.');
+        }
+
+        $previousScale = bcscale();
+        bcscale(8);
+
+        try {
+            self::assertSame('0.1', (string) BigDecimal::of(1)->exactlyDividedBy(10));
+        } finally {
+            bcscale($previousScale);
+        }
+    }
+
     /**
      * @dataProvider providerDividedByWithRoundingNecessaryThrowsException
      *