Skip to content

Commit

Permalink
Add getSign() method to BigInteger and BigDecimal
Browse files Browse the repository at this point in the history
  • Loading branch information
@BenMorel
BenMorel committed Jun 7, 2015
1 parent 2aabbe1 commit e9da17c
Show file tree
Hide file tree
Showing 4 changed files with 94 additions and 52 deletions.
10 changes: 10 additions & 0 deletions src/BigDecimal.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,16 @@ public function isGreaterThanOrEqualTo($that)
return $this->compareTo($that) >= 0;
}

/**
* Returns the sign of this number.
*
* @return int -1 if the number is negative, 0 if zero, 1 if positive.
*/
public function getSign()
{
return ($this->value === '0') ? 0 : (($this->value[0] === '-') ? -1 : 1);
}

/**
* Checks if this number equals zero.
*
Expand Down
10 changes: 10 additions & 0 deletions src/BigInteger.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,16 @@ public function isGreaterThanOrEqualTo($that)
return $this->compareTo($that) >= 0;
}

/**
* Returns the sign of this number.
*
* @return int -1 if the number is negative, 0 if zero, 1 if positive.
*/
public function getSign()
{
return ($this->value === '0') ? 0 : (($this->value[0] === '-') ? -1 : 1);
}

/**
* Checks if this number equals zero.
*
Expand Down
63 changes: 37 additions & 26 deletions tests/BigDecimalTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1702,64 +1702,75 @@ public function providerCompareTo()
}

/**
* @dataProvider providerCompareToZero
* @dataProvider providerSign
*
* @param string|number $number The number to test.
* @param boolean $cmp The comparison value.
* @param number|string $number The number to test.
* @param int $sign The sign of the number.
*/
public function testIsZero($number, $cmp)
public function testGetSign($number, $sign)
{
$this->assertSame($cmp == 0, BigDecimal::of($number)->isZero());
$this->assertSame($sign, BigDecimal::of($number)->getSign());
}

/**
* @dataProvider providerCompareToZero
* @dataProvider providerSign
*
* @param string|number $number The number to test.
* @param boolean $cmp The comparison value.
* @param number|string $number The number to test.
* @param int $sign The sign of the number.
*/
public function testIsNegative($number, $cmp)
public function testIsZero($number, $sign)
{
$this->assertSame($cmp < 0, BigDecimal::of($number)->isNegative());
$this->assertSame($sign === 0, BigDecimal::of($number)->isZero());
}

/**
* @dataProvider providerCompareToZero
* @dataProvider providerSign
*
* @param string|number $number The number to test.
* @param boolean $cmp The comparison value.
* @param number|string $number The number to test.
* @param int $sign The sign of the number.
*/
public function testIsNegativeOrZero($number, $cmp)
public function testIsNegative($number, $sign)
{
$this->assertSame($cmp <= 0, BigDecimal::of($number)->isNegativeOrZero());
$this->assertSame($sign < 0, BigDecimal::of($number)->isNegative());
}

/**
* @dataProvider providerCompareToZero
* @dataProvider providerSign
*
* @param string|number $number The number to test.
* @param boolean $cmp The comparison value.
* @param number|string $number The number to test.
* @param int $sign The sign of the number.
*/
public function testIsPositive($number, $cmp)
public function testIsNegativeOrZero($number, $sign)
{
$this->assertSame($cmp > 0, BigDecimal::of($number)->isPositive());
$this->assertSame($sign <= 0, BigDecimal::of($number)->isNegativeOrZero());
}

/**
* @dataProvider providerCompareToZero
* @dataProvider providerSign
*
* @param string|number $number The number to test.
* @param boolean $cmp The comparison value.
* @param number|string $number The number to test.
* @param int $sign The sign of the number.
*/
public function testIsPositiveOrZero($number, $cmp)
public function testIsPositive($number, $sign)
{
$this->assertSame($cmp >= 0, BigDecimal::of($number)->isPositiveOrZero());
$this->assertSame($sign > 0, BigDecimal::of($number)->isPositive());
}

/**
* @dataProvider providerSign
*
* @param number|string $number The number to test.
* @param int $sign The sign of the number.
*/
public function testIsPositiveOrZero($number, $sign)
{
$this->assertSame($sign >= 0, BigDecimal::of($number)->isPositiveOrZero());
}

/**
* @return array
*/
public function providerCompareToZero()
public function providerSign()
{
return [
[ 0, 0],
Expand Down
63 changes: 37 additions & 26 deletions tests/BigIntegerTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1347,64 +1347,75 @@ public function providerCompareTo()
}

/**
* @dataProvider providerCompareToZero
* @dataProvider providerSign
*
* @param string|integer $number The number to test.
* @param boolean $cmp The comparison value.
* @param int|string $number The number to test.
* @param int $sign The sign of the number.
*/
public function testIsZero($number, $cmp)
public function testGetSign($number, $sign)
{
$this->assertSame($cmp == 0, BigInteger::of($number)->isZero());
$this->assertSame($sign, BigInteger::of($number)->getSign());
}

/**
* @dataProvider providerCompareToZero
* @dataProvider providerSign
*
* @param string|integer $number The number to test.
* @param boolean $cmp The comparison value.
* @param int|string $number The number to test.
* @param int $sign The sign of the number.
*/
public function testIsNegative($number, $cmp)
public function testIsZero($number, $sign)
{
$this->assertSame($cmp < 0, BigInteger::of($number)->isNegative());
$this->assertSame($sign == 0, BigInteger::of($number)->isZero());
}

/**
* @dataProvider providerCompareToZero
* @dataProvider providerSign
*
* @param string|integer $number The number to test.
* @param boolean $cmp The comparison value.
* @param int|string $number The number to test.
* @param int $sign The sign of the number.
*/
public function testIsNegativeOrZero($number, $cmp)
public function testIsNegative($number, $sign)
{
$this->assertSame($cmp <= 0, BigInteger::of($number)->isNegativeOrZero());
$this->assertSame($sign < 0, BigInteger::of($number)->isNegative());
}

/**
* @dataProvider providerCompareToZero
* @dataProvider providerSign
*
* @param string|integer $number The number to test.
* @param boolean $cmp The comparison value.
* @param int|string $number The number to test.
* @param int $sign The sign of the number.
*/
public function testIsPositive($number, $cmp)
public function testIsNegativeOrZero($number, $sign)
{
$this->assertSame($cmp > 0, BigInteger::of($number)->isPositive());
$this->assertSame($sign <= 0, BigInteger::of($number)->isNegativeOrZero());
}

/**
* @dataProvider providerCompareToZero
* @dataProvider providerSign
*
* @param string|integer $number The number to test.
* @param boolean $cmp The comparison value.
* @param int|string $number The number to test.
* @param int $sign The sign of the number.
*/
public function testIsPositiveOrZero($number, $cmp)
public function testIsPositive($number, $sign)
{
$this->assertSame($cmp >= 0, BigInteger::of($number)->isPositiveOrZero());
$this->assertSame($sign > 0, BigInteger::of($number)->isPositive());
}

/**
* @dataProvider providerSign
*
* @param int|string $number The number to test.
* @param int $sign The sign of the number.
*/
public function testIsPositiveOrZero($number, $sign)
{
$this->assertSame($sign >= 0, BigInteger::of($number)->isPositiveOrZero());
}

/**
* @return array
*/
public function providerCompareToZero()
public function providerSign()
{
return [
[ 0, 0],
Expand Down

0 comments on commit e9da17c

Please sign in to comment.