Skip to content

Commit

Permalink
[libc][math] Fix issignaling macro usage in the implementation. (llvm…
Browse files Browse the repository at this point in the history
  • Loading branch information
lntue authored and bricknerb committed Oct 17, 2024
1 parent b129f64 commit 569a94a
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 6 deletions.
3 changes: 2 additions & 1 deletion libc/src/__support/FPUtil/BasicOperations.h
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,9 @@ LIBC_INLINE T fdim(T x, T y) {
return (x > y ? x - y : 0);
}

// Avoid reusing `issignaling` macro.
template <typename T, cpp::enable_if_t<cpp::is_floating_point_v<T>, int> = 0>
LIBC_INLINE int issignaling(const T &x) {
LIBC_INLINE int issignaling_impl(const T &x) {
FPBits<T> sx(x);
return sx.is_signaling_nan();
}
Expand Down
2 changes: 1 addition & 1 deletion libc/src/math/generic/issignaling.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
namespace LIBC_NAMESPACE_DECL {

LLVM_LIBC_FUNCTION(int, issignaling, (double x)) {
return fputil::issignaling(x);
return fputil::issignaling_impl(x);
}

} // namespace LIBC_NAMESPACE_DECL
2 changes: 1 addition & 1 deletion libc/src/math/generic/issignalingf.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
namespace LIBC_NAMESPACE_DECL {

LLVM_LIBC_FUNCTION(int, issignalingf, (float x)) {
return fputil::issignaling(x);
return fputil::issignaling_impl(x);
}

} // namespace LIBC_NAMESPACE_DECL
2 changes: 1 addition & 1 deletion libc/src/math/generic/issignalingf128.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
namespace LIBC_NAMESPACE_DECL {

LLVM_LIBC_FUNCTION(int, issignalingf128, (float128 x)) {
return fputil::issignaling(x);
return fputil::issignaling_impl(x);
}

} // namespace LIBC_NAMESPACE_DECL
2 changes: 1 addition & 1 deletion libc/src/math/generic/issignalingf16.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
namespace LIBC_NAMESPACE_DECL {

LLVM_LIBC_FUNCTION(int, issignalingf16, (float16 x)) {
return fputil::issignaling(x);
return fputil::issignaling_impl(x);
}

} // namespace LIBC_NAMESPACE_DECL
2 changes: 1 addition & 1 deletion libc/src/math/generic/issignalingl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
namespace LIBC_NAMESPACE_DECL {

LLVM_LIBC_FUNCTION(int, issignalingl, (long double x)) {
return fputil::issignaling(x);
return fputil::issignaling_impl(x);
}

} // namespace LIBC_NAMESPACE_DECL

0 comments on commit 569a94a

Please sign in to comment.