Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arm): EventHubNamespaceMinTLS12 #6485

Merged

Conversation

shoshiGit
Copy link
Contributor

@shoshiGit shoshiGit commented Jun 24, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

We converted the check 'EventHubNamespaceMinTLS12' from TERRAFORM language to the ARM language so that it also works on resources that are defined in the ARM language.

Fixes # (issue)

Description

Ensure Event Hub Namespace uses at least TLS 1.2.

Fix

To fix the issue in code, update the Event Hub Namespace configuration to enforce a minimum of TLS 1.2. This can be done by modifying the ARM template to include the appropriate TLS settings for the Event Hub Namespace.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@matansha
Copy link
Contributor

Hi @shoshiGit , Thanks for your contribution, please add test if the TLS value is 1.3
Hint: it should pass

Copy link
Contributor

@ChanochShayner ChanochShayner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ChanochShayner ChanochShayner merged commit aa7d9fc into bridgecrewio:main Jul 3, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants