feat(general): In toto output format #6488
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaraWeinberg1234
had a problem deploying
to
scan-security
GitHub Actions
Failure
|
Hi @SaraWeinberg1234, Thanks for your contribution, please add some tests |
SaraWeinberg1234
changed the title
SaraWeinberg1234
had a problem deploying
to
scan-security
GitHub Actions
Failure
SaraWeinberg1234
had a problem deploying
to
scan-security
GitHub Actions
Failure
|
Looks good to me! |
tsmithv11
requested changes
Jul 16, 2024
| { | ||
| "name": "", | ||
| "digest": { | ||
| "sha256": "fe4fe40ac7250263c5dbe1cf3138912f3f416140aa248637a60d65fe22c47da4" |
There was a problem hiding this comment.
I believe this should be calculated not static
| for check in report.failed_checks: | ||
| in_toto_data["predicate"]["invocation"]["uri"] = "https://github.com/developer-guy/alpine/actions/runs/1071875574" | ||
| in_toto_data["predicate"]["invocation"]["event_id"] = "1071875574" | ||
| in_toto_data["predicate"]["invocation"]["builder.id"] = "GitHub Actions" |
There was a problem hiding this comment.
This should be based on the use of Checkov not static
|
|
||
| for report in self.reports: | ||
| for check in report.failed_checks: | ||
| in_toto_data["predicate"]["invocation"]["uri"] = "https://github.com/developer-guy/alpine/actions/runs/1071875574" |
There was a problem hiding this comment.
I believe this should not be static
| in_toto_data["predicate"]["invocation"]["uri"] = "https://github.com/developer-guy/alpine/actions/runs/1071875574" | ||
| in_toto_data["predicate"]["invocation"]["event_id"] = "1071875574" | ||
| in_toto_data["predicate"]["invocation"]["builder.id"] = "GitHub Actions" | ||
| in_toto_data["predicate"]["scanner"]["uri"] = "pkg:github/aquasecurity/trivy@244fd47e07d1004f0aed9" |
There was a problem hiding this comment.
This should be Checkov not Trivy and the version should not be static
| "id": check.check_id, | ||
| "severity": [ | ||
| { | ||
| "method": "nvd", |
There was a problem hiding this comment.
Suggested change
| "method": "nvd", | |
| "method": "vendor", |
SaraWeinberg1234
had a problem deploying
to
scan-security
GitHub Actions
Failure
SaraWeinberg1234
force-pushed
the
InTotoOutputFormat
branch
from
2b2948c
to
0d14fe1
Compare
SaraWeinberg1234
had a problem deploying
to
scan-security
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
in-toto Attestation
fixes: #6208
Description
Added output of in-toto Attestation format
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: