Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secrets): Fix empty supported files not scan in multiline #6489

Closed
wants to merge 3 commits into from

Conversation

matansha
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@matansha matansha changed the title feat(secret): Fix empty supported files not scan in multiline feat(secrets): Fix empty supported files not scan in multiline Jun 24, 2024
Copy link
Contributor

@pazbechor pazbechor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this property will cause catastrophic performance. Please add your Multiline secret supported files in the secrets_policies.json

@matansha matansha force-pushed the fix_secrets_multiline_supported_files branch from 46827d6 to 940b7f4 Compare June 30, 2024 14:14
@pazbechor pazbechor self-requested a review July 1, 2024 06:33
@matansha matansha closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants