feat(arm): add CKV_AZURE_191 to ensure that Managed identity provider is enabled for Azure Event Grid Topic #6496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RachelBorzi
had a problem deploying
to
scan-security
GitHub Actions
Failure
| # Regular checks of the monitored path allow Azure App Service to route traffic based on availability." | ||
| name = "Ensure that App Service configures health check" | ||
| id = "CKV_AZURE_213" | ||
| supported_resources = ('Microsoft.Web/sites', 'Microsoft.Web/sites/slots',) |
There was a problem hiding this comment.
You can add Microsoft.Web/sites/config to the supported resource_types.
| supported_resources = ("Microsoft.EventGrid/topics",) | ||
| categories = (CheckCategories.IAM,) | ||
| super().__init__(name=name, id=id, categories=categories, supported_resources=supported_resources) | ||
|
|
There was a problem hiding this comment.
should be missing_block_result passed, as the default value here is false.
There was a problem hiding this comment.
I was wrong, shouldnt be missing_block_result=CheckResult.PASSED
| return "properties/publicNetworkAccess" | ||
|
|
||
| def get_expected_value(self) -> str: | ||
| return "disabled" |
There was a problem hiding this comment.
It should be Upper Case -> Disabled and Enabled.
ChanochShayner
approved these changes
Jun 27, 2024
itai1357
approved these changes
Jul 18, 2024
RachelBorzi
had a problem deploying
to
scan-security
GitHub Actions
Failure
ChanochShayner
approved these changes
Jul 21, 2024
| return "properties/disableLocalAuth" | ||
|
|
||
| def get_expected_value(self) -> bool: | ||
| return False |
There was a problem hiding this comment.
Suggested change
| return False | |
| return True |
| supported_resources = ("Microsoft.EventGrid/topics",) | ||
| categories = (CheckCategories.IAM,) | ||
| super().__init__(name=name, id=id, categories=categories, supported_resources=supported_resources) | ||
|
|
There was a problem hiding this comment.
I was wrong, shouldnt be missing_block_result=CheckResult.PASSED
RachelBorzi
had a problem deploying
to
scan-security
GitHub Actions
Failure
RachelBorzi
temporarily deployed
to
scan-security
GitHub Actions
Inactive
checkov/arm/checks/resource/EventgridTopicLocalAuthentication.py
Outdated
Show resolved
Hide resolved
ChanochShayner
temporarily deployed
to
scan-security
GitHub Actions
Inactive
dtrouillet
pushed a commit
to dtrouillet/checkov_severity
that referenced
this pull request
Jul 24, 2024
… is enabled for Azure Event Grid Topic (bridgecrewio#6496) * feat(ARM): AppServiceSetHealthCheck CKV_AZURE_213 * feat(arm): CKV_AZURE_193 * feat(arm): CKV_AZURE_192 * feat(arm): CKV_AZURE_191 * fix * fix * git commit -m "Remove check * Update checkov/arm/checks/resource/EventgridTopicLocalAuthentication.py --------- Co-authored-by: Rachel <bb50305030@gmail.com> Co-authored-by: ChanochShayner <57212002+ChanochShayner@users.noreply.github.com>
dtrouillet
pushed a commit
to dtrouillet/checkov_severity
that referenced
this pull request
Jul 24, 2024
… is enabled for Azure Event Grid Topic (bridgecrewio#6496) * feat(ARM): AppServiceSetHealthCheck CKV_AZURE_213 * feat(arm): CKV_AZURE_193 * feat(arm): CKV_AZURE_192 * feat(arm): CKV_AZURE_191 * fix * fix * git commit -m "Remove check * Update checkov/arm/checks/resource/EventgridTopicLocalAuthentication.py --------- Co-authored-by: Rachel <bb50305030@gmail.com> Co-authored-by: ChanochShayner <57212002+ChanochShayner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Added new policy for -
EventgridTopicIdentityProviderEnabled - CKV_AZURE_191
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
policy to ensure that Managed identity provider is enabled for Azure Event Grid Topic
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: