feat(arm): ARM AppServiceInstanceMinimum - CKV_AZURE_212 #6502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RachelBorzi
had a problem deploying
to
scan-security
GitHub Actions
Failure
RachelBorzi
had a problem deploying
to
scan-security
GitHub Actions
Failure
| def scan_resource_conf(self, conf: Dict[str, Dict[str, Dict[str, int]]]) -> CheckResult: | ||
| if "properties" in conf: | ||
| if "siteConfig" in conf["properties"]: | ||
| if "numberOfWorkers" in conf["properties"]["siteConfig"]: |
There was a problem hiding this comment.
Please verify siteConfic before accessing it, you can see the dogFood test is failing on it.
RachelBorzi
temporarily deployed
to
scan-security
GitHub Actions
Inactive
| from checkov.common.models.enums import CheckCategories, CheckResult | ||
|
|
||
|
|
||
| class AppServiceSlotMinTLS(BaseResourceValueCheck): |
There was a problem hiding this comment.
Please remove this check from your PR, we already have this check for those resources in CKV_AZURE_15 & CKV_AZURE_145
ChanochShayner
approved these changes
Jul 24, 2024
RachelBorzi
temporarily deployed
to
scan-security
GitHub Actions
Inactive
RachelBorzi
temporarily deployed
to
scan-security
GitHub Actions
Inactive
SteveVaknin
approved these changes
Jul 28, 2024
|
|
||
| def scan_resource_conf(self, conf: Dict[str, Dict[str, Dict[str, int]]]) -> CheckResult: | ||
| if "properties" in conf: | ||
| if "siteConfig" in conf["properties"] and conf["properties"]["siteConfig"] is not None: |
There was a problem hiding this comment.
consider working with get instead, it is less complex and more readable. If the key doesn't exists it will return None.
Suggested change
| if "siteConfig" in conf["properties"] and conf["properties"]["siteConfig"] is not None: | |
| if conf.get("properties").get("siteConfig") is not None: |
RachelBorzi
temporarily deployed
to
scan-security
GitHub Actions
Inactive
ChanochShayner
temporarily deployed
to
scan-security
GitHub Actions
Inactive
ChanochShayner
added a commit
to channy-katz/checkov
that referenced
this pull request
Jul 29, 2024
…o#6502) * feat(ARM): AppServiceSetHealthCheck CKV_AZURE_213 * feat(arm) CKV_AZURE_154 * feat(arm) CKV_AZURE_212 * type return * verify siteConfig * remove check AppServiceSlotMinTLS * changed line 23 * Update checkov/arm/checks/resource/AppServiceInstanceMinimum.py --------- Co-authored-by: Rachel <bb50305030@gmail.com> Co-authored-by: ChanochShayner <57212002+ChanochShayner@users.noreply.github.com>
ChanochShayner
added a commit
to channy-katz/checkov
that referenced
this pull request
Jul 29, 2024
…o#6502) * feat(ARM): AppServiceSetHealthCheck CKV_AZURE_213 * feat(arm) CKV_AZURE_154 * feat(arm) CKV_AZURE_212 * type return * verify siteConfig * remove check AppServiceSlotMinTLS * changed line 23 * Update checkov/arm/checks/resource/AppServiceInstanceMinimum.py --------- Co-authored-by: Rachel <bb50305030@gmail.com> Co-authored-by: ChanochShayner <57212002+ChanochShayner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Added new policy for -
AppServiceInstanceMinimum - CKV_AZURE_212
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
policy to ensure App Service has a minimum number of instances for failover
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: