-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(general): Allow skipping multiple checks in a single line #6512
Closed
shoshiGit
wants to merge
11
commits into
bridgecrewio:main
from
shoshiGit:Multiple_Skipps_In_One_Line
Closed
feat(general): Allow skipping multiple checks in a single line #6512
shoshiGit
wants to merge
11
commits into
bridgecrewio:main
from
shoshiGit:Multiple_Skipps_In_One_Line
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoshiGit
had a problem deploying
to
scan-security
June 30, 2024 10:29
— with
GitHub Actions
Failure
shoshiGit
had a problem deploying
to
scan-security
June 30, 2024 10:29
— with
GitHub Actions
Failure
ChanochShayner
changed the title
feat(checkov): Allow skipping multiple checks in a single line
feat(general): Allow skipping multiple checks in a single line
Jun 30, 2024
shoshiGit
had a problem deploying
to
scan-security
June 30, 2024 10:37
— with
GitHub Actions
Failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Please add UTs -
- Ensure we can skip more than one violation in one line.
- Ensure invalid addition in the line still work as expected, like - checkov:skip=CKV_AWS_4,Bla_Bla_Bla
esterKoren
had a problem deploying
to
scan-security
June 30, 2024 10:39
— with
GitHub Actions
Failure
…o Multiple_Skipps_In_One_Line
shoshiGit
had a problem deploying
to
scan-security
June 30, 2024 13:21
— with
GitHub Actions
Failure
shoshiGit
had a problem deploying
to
scan-security
July 28, 2024 10:22
— with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
This pull request enhances Checkov to support skipping multiple checks in a single line for Terraform configurations. Currently, individual skip comments are required for each check, which can be cumbersome. This enhancement allows specifying multiple checks to skip in a single line.
Fixes # #5381
Changes made:
Added functionality to parse multiple checks in the
checkov:skip
comment.Updated documentation to reflect the new capability.
Checklist: