Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arm): NSGRuleUDPAccessRestricted #6514

Closed

Conversation

esterKoren
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

We converted the check NSGRuleUDPAccessRestricted from TERRAFORM language to the ARM language so that it also works on resources that are defined in the ARM language

Description

Ensure that UDP Services are restricted from the Internet.

Fix

To address the issue of converting the NSGRuleUDPAccessRestricted check from Terraform language to ARM language, the following steps were taken*

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

@esterKoren esterKoren changed the title faet(arm): NSGRuleUDPAccessRestricted feat(arm): NSGRuleUDPAccessRestricted Jul 2, 2024
evaluated_key_prefix = 'securityRules/'
for rule_conf in rule_confs:
if isinstance(rule_conf, dict):
# print('\n',rule_conf)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete this line

@itai1357
Copy link
Contributor

Hi @esterKoren
TNX a lot for contributing!

there are some linting issues. please check here: https://github.com/bridgecrewio/checkov/actions/runs/9991325627/job/27613901106?pr=6514

@ChanochShayner
Copy link
Contributor

Closing, feel free to reopen if this PR is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants