Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform_plan): support tf_plan after_unknown enrichment #6517

Merged
merged 10 commits into from
Jul 10, 2024
Merged

feat(terraform_plan): support tf_plan after_unknown enrichment #6517

merged 10 commits into from
Jul 10, 2024

Conversation

maxamel
Copy link
Contributor

@maxamel maxamel commented Jul 1, 2024 •
edited
Loading

This PR adds support for tf_plan conf enrichment with after_unknown values.
We only support first level fields for now, and only check existence of the fields, not actual values.
This is protected by env var for now.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

@maxamel maxamel changed the title add first code content to run tests feat(terraform_plan): support tf_plan after_unknown enrichment Jul 1, 2024
@maxamel maxamel marked this pull request as ready for review July 9, 2024 06:22
@maxamel maxamel merged commit d80b1f1 into main Jul 10, 2024
41 checks passed
@maxamel maxamel deleted the eval_tf_plan_after_unknown branch July 10, 2024 07:40
shoshiGit pushed a commit to shoshiGit/shoshi-wolpe-checkov that referenced this pull request Jul 10, 2024
@maxamel @actions-user
feat(terraform_plan): support tf_plan after_unknown enrichment (bridg…
d64acd5 
…ecrewio#6517)

* add first code content to run tests

* remove flag for testing

* fix S3BucketObject check to check for dict

* change code to reflect after_unknown

* add flag for eval of tf_plan after_unknown

* fix according to comments

* fix mypy issue

---------

Co-authored-by: Max Amelchenko <mamelchenko@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bo156 bo156 bo156 approved these changes

@lirshindalman lirshindalman lirshindalman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxamel @bo156 @lirshindalman