Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(azure): add new policies for Azure Synapse #6520

Merged
merged 9 commits into from
Jul 4, 2024

Conversation

taviassaf
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

@taviassaf taviassaf changed the title add terraform policies support azure synapse analytics policies Jul 1, 2024
@taviassaf taviassaf changed the title support azure synapse analytics policies support azure synapse analytics policies (Terraform, ARM) Jul 1, 2024
@taviassaf taviassaf self-assigned this Jul 3, 2024
Copy link
Contributor

@lirshindalman lirshindalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!

Copy link
Contributor

@SteveVaknin SteveVaknin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Left some comments

@SteveVaknin SteveVaknin changed the title support azure synapse analytics policies (Terraform, ARM) feat(azure): add new policies for Azure Synapse Jul 3, 2024
@taviassaf taviassaf deployed to scan-security July 4, 2024 08:01 — with GitHub Actions Active
Copy link
Contributor

@SteveVaknin SteveVaknin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taviassaf Amazing first contribution! 👏 🔝

@SteveVaknin SteveVaknin merged commit 50b60be into main Jul 4, 2024
41 checks passed
@SteveVaknin SteveVaknin deleted the support-azure-synapse-analytics-policies branch July 4, 2024 08:36
shoshiGit pushed a commit to shoshiGit/shoshi-wolpe-checkov that referenced this pull request Jul 4, 2024
* add terraform policies

* add tests and update policies

* update and remove two checks

* add SynapseWorkspaceHasExtendedAuditLogs test

* add SynapseWorkspaceAdministratorLoginPasswordHidden and SQLPoolMonitoringEabled test

* fix cr issues

* fix cr issues

* fix cr issues

* fix lint issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants