fix(secrets): multiline matches show the secret and not the first line #6854
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Improve the
CustomRegexDetector
to correctly display multiline secrets by introducing a new functionfind_line_number
to accurately determine the line number of secrets. Enhance test coverage with a new test caseTestMultilineFinding
to validate the changes.CustomRegexDetector
by quoting the secret and accurately finding its line number usingfind_line_number
.Modified files (1)
Latest Contributors(2)
TestMultilineFinding
to ensure multiline secret detection works correctly, using a sample Dockerfile for testing.Modified files (2)
Latest Contributors(0)