-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: generator 7.7.3 update #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Aug 16, 2019
brandonocasey
commented
Aug 16, 2019
input: 'src/unpad.js', | ||
output: [{ | ||
name: 'pkcs7.unpad', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we minify all files named .min.js
now. so we can make the build much faster by using two outputs.
brandonocasey
commented
Aug 16, 2019
@@ -49,9 +49,11 @@ QUnit.test('works on buffers greater than sixteen bytes', function(assert) { | |||
|
|||
assert.expect(2); | |||
|
|||
assert.equal(pkcs7.pad(buffer).length - buffer.length, | |||
assert.equal( | |||
pkcs7.pad(buffer).length - buffer.length, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
liner fixes.
brandonocasey
force-pushed
the
chore/generator-update
branch
from
August 16, 2019 21:50
02e0881
to
c791c18
Compare
6 tasks
gkatsev
approved these changes
Aug 19, 2019
brandonocasey
force-pushed
the
chore/generator-update
branch
from
August 21, 2019 21:02
fac4ccf
to
d92c1e3
Compare
brandonocasey
force-pushed
the
chore/generator-update
branch
from
August 21, 2019 21:04
d92c1e3
to
42529a0
Compare
brandonocasey
changed the title
chore: generator 7.7.0 update
chore: generator 7.7.3 update
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.