Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading packages and fixing type issues #11

Closed

Conversation

krainboltgreene
Copy link

So I wanted to make some modifications to the library, but I found it was quite out of date. I attempted to update a few things:

  1. jest now has a codified way to deal with typescript, via babel
  2. I made the gitignore a little more sane
  3. I updated all the packages I could, the devDependencies having no issues
  4. Removed the unused @types/archiver

Here's some things I ran across:

  1. postcss, camelcase, and postcss-selector-parser all have type definitions
    - postcss-selector-parser doesn't export theirs (Not exposing types? postcss/postcss-selector-parser#235), so I tried (and failed) to do it myself locally
  2. All three libraries have changed how they expose themselves to imports, so I corrected as much as I could
  3. Some of the types no longer make sense (Node -> AnyNode)
  4. I was completely unable to figure out how exactly they changed the Stringify/builder stuff, but they did and now it no longer works.

@krainboltgreene krainboltgreene marked this pull request as draft November 27, 2020 08:42
@krainboltgreene
Copy link
Author

The much more correct #17 is passing tests.

@krainboltgreene krainboltgreene deleted the upgrading-packages branch November 28, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant