Add aria-expanded attribute to rows
#223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this! My project also needs this update, hopefully it gets merged soon! |
lidiagc
force-pushed
the
lidiagc/add-aria-expanded-attribute
branch
from
9c7a9f3
to
7fe01ca
Compare
|
Thank you for submitting this! We want this update in our feature too. It would be really nice to get this shipped so we avoid creating a patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On our own project, we saw the need to add the attribute
aria-expandedto the row elements, since it makes it easier to test with cypress.This PR adds the attribute
aria-expandedto the row container with the valuenode.isOpen.Also updated the tests to verify the change.