collect: untag union values (#4932)

Closes #4707
brimdata · Dec 19, 2023 · a246bfe · a246bfe
1 parent b7d3b41
commit a246bfe
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/runtime/expr/agg/collect.go b/runtime/expr/agg/collect.go
@@ -22,7 +22,7 @@ func (c *Collect) Consume(val *zed.Value) {
 }
 
 func (c *Collect) update(val *zed.Value) {
-	c.values = append(c.values, *val.Copy())
+	c.values = append(c.values, *val.Under(&zed.Value{}).Copy())
 	c.size += len(val.Bytes())
 	for c.size > MaxValueSize {
 		// XXX See issue #1813.  For now we silently discard entries

diff --git a/runtime/expr/agg/ztests/collect-untag-unions.yaml b/runtime/expr/agg/ztests/collect-untag-unions.yaml
@@ -0,0 +1,9 @@
+zed: collect(this)
+
+input: |
+  1((int64,string))
+  "foo"((time,string))
+  0.5
+
+output: |
+  [1,"foo",0.5]