Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle multiple pool keys #2657

Open
mccanne opened this issue May 3, 2021 · 4 comments · Fixed by #4903
Open

handle multiple pool keys #2657

mccanne opened this issue May 3, 2021 · 4 comments · Fixed by #4903
Assignees

Comments

@mccanne
Copy link
Collaborator

mccanne commented May 3, 2021

e.g., primary, second etc keys should be allowed for pools. The data structures are all set up for this but the compiler and optimizer currently assume a single primary key.

Also, dag.Merge will need to handle multiple keys and dag.Merge.Reverse + Key should be replaced with order.Layout.

@philrz philrz modified the milestones: Data MVP1, Data MVP0 May 5, 2021
@philrz
Copy link
Contributor

philrz commented May 6, 2021

@mccanne senses he may be able to knock this one out quickly shortly after he addresses #2482, but if this turns out to be harder than we thought, we agreed that we can push it out to MVP1.

@philrz philrz modified the milestones: Data MVP0, Data MVP1 May 10, 2021
@mattnibs mattnibs assigned mattnibs and unassigned mccanne Jul 16, 2021
@philrz
Copy link
Contributor

philrz commented Aug 20, 2021

Note to self: When this gets implemented, remove the reference to this issue from the Zed lake design doc.

@philrz philrz removed this from the ETL Lake milestone Oct 25, 2022
@mccanne
Copy link
Collaborator Author

mccanne commented Apr 21, 2023

optimizer needs to handle multi-sort keys too

@philrz
Copy link
Contributor

philrz commented Nov 7, 2023

We discussed this one again recently and figured we could continue postponing implementation until we have more traction with the lake. But in the short term we should have the tooling prevent the configuration of multiple pool keys and kick back a message referencing this issue so we can find out if there's demand from users that need it. (#4596)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants