Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow creation of multi-key pools #4903

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Disallow creation of multi-key pools #4903

merged 1 commit into from
Nov 30, 2023

Conversation

mattnibs
Copy link
Collaborator

Closes #4596

@mattnibs mattnibs requested a review from a team November 28, 2023 22:13
@mattnibs mattnibs force-pushed the single-pool-key branch 3 times, most recently from 99d1cb2 to 554c117 Compare November 28, 2023 22:52
nwt
nwt reviewed Nov 29, 2023
View reviewed changes
lake/root.go Show resolved Hide resolved
@mattnibs mattnibs requested a review from nwt November 29, 2023 17:49
@mattnibs mattnibs merged commit beb2760 into main Nov 30, 2023
3 checks passed
@mattnibs mattnibs deleted the single-pool-key branch November 30, 2023 17:40
zmajeed pushed a commit to zmajeedforks/zed that referenced this pull request Dec 6, 2023
@mattnibs @zmajeed
Disallow creation of multi-key pools (brimdata#4903)
0b13f5f 
Closes brimdata#4596
@philrz philrz linked an issue Dec 13, 2023 that may be closed by this pull request
handle multiple pool keys #2657
Open
@philrz philrz mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwt nwt nwt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

handle multiple pool keys Prevent creation of multi-key pools (or inform users it's unsupported)
2 participants
@mattnibs @nwt