-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backend API support for "vng" input #4251
Comments
philrz
changed the title
Add backend API support for "zst" input
Add backend API support for "vng" input
Dec 12, 2022
nwt
added a commit
that referenced
this issue
Jan 30, 2023
* Send a VNG response for an API request whose negotiated content type is application/x-vng. * When loading data via POST /pool/{pool}/branch/{branch}, if the request content type is application/x-vng, copy the request body to a temporary file for the benefit of the VNG reader, which needs a reader that implements io.ReaderAt and io.Seeker. Closes #4251.
nwt
added a commit
that referenced
this issue
Jan 30, 2023
* Send a VNG response for an API request whose negotiated content type is application/x-vng. * When loading data via POST /pool/{pool}/branch/{branch}, if the request content type is application/x-vng, copy the request body to a temporary file for the benefit of the VNG reader, which needs a reader that implements io.ReaderAt and io.Seeker. Closes #4251.
nwt
added a commit
that referenced
this issue
Jan 31, 2023
* Send a VNG response for an API request whose negotiated content type is application/x-vng. * When loading data via POST /pool/{pool}/branch/{branch}, if the request content type is application/x-vng, copy the request body to a temporary file for the benefit of the VNG reader, which needs a reader that implements io.ReaderAt and io.Seeker. Closes #4251.
Verified in Zed commit 743eebd using the attached sample.vng.gz.
Using this to add VNG support in the app is tracked in brimdata/zui#2650. Thanks @nwt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Repro is with Zed commit 723a6e9.
VNG can currently be loaded via
-i vng
with the Zed CLI tooling. However, the Zed CLI tooling currently handles all input by first turning it into ZNG within the client and posting it to the backend as ZNG. Meanwhile, the Brim app and lake API both post data in native formats and rely on the backend to read in that format. Therefore to have feature parity between our different clients & API it would be ideal to add VNG load support in the backend as well.How things look at the moment in Zed commit 723a6e9 and the attached test data sample.vng.gz (after uncompressing):
In addition to adding the MIME type, @nwt is aware of what else is needed:
The text was updated successfully, but these errors were encountered: