lake: make rangeWrapper filters safe for concurrent use #2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of concurrency in the ZNG scanner, separate filters returned by a zbuf.Filter's methods must be safe for concurrent use in separate goroutines. Filters returned by lake.rangeWrapper.AsFilter do not have this property because they share the single expr.ValueCompareFn in rangeWrapper.compare. Fix this by creating a new expr.ValueCompareFn for each filter returned.
mccanne
approved these changes
Aug 27, 2021
brim-bot
pushed a commit
to brimdata/brimcap
that referenced
this pull request
Aug 27, 2021
…nt use" by nwt This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/super#2969, authored by @nwt, has been merged. lake: make rangeWrapper filters safe for concurrent use Because of concurrency in the ZNG scanner, separate filters returned by a zbuf.Filter's methods must be safe for concurrent use in separate goroutines. Filters returned by lake.rangeWrapper.AsFilter do not have this property because they share the single expr.ValueCompareFn in rangeWrapper.compare. Fix this by creating a new expr.ValueCompareFn for each filter returned. Closes brimdata/super#2960.
brim-bot
pushed a commit
to brimdata/brimcap
that referenced
this pull request
Aug 27, 2021
…nt use" by nwt This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/super#2969, authored by @nwt, has been merged. lake: make rangeWrapper filters safe for concurrent use Because of concurrency in the ZNG scanner, separate filters returned by a zbuf.Filter's methods must be safe for concurrent use in separate goroutines. Filters returned by lake.rangeWrapper.AsFilter do not have this property because they share the single expr.ValueCompareFn in rangeWrapper.compare. Fix this by creating a new expr.ValueCompareFn for each filter returned. Closes brimdata/super#2960.
brim-bot
pushed a commit
to brimdata/zui
that referenced
this pull request
Aug 27, 2021
…nt use" by nwt This is an auto-generated commit with a Zed dependency update. The Zed PR brimdata/super#2969, authored by @nwt, has been merged. lake: make rangeWrapper filters safe for concurrent use Because of concurrency in the ZNG scanner, separate filters returned by a zbuf.Filter's methods must be safe for concurrent use in separate goroutines. Filters returned by lake.rangeWrapper.AsFilter do not have this property because they share the single expr.ValueCompareFn in rangeWrapper.compare. Fix this by creating a new expr.ValueCompareFn for each filter returned. Closes brimdata/super#2960.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of concurrency in the ZNG scanner, separate filters returned by
a zbuf.Filter's methods must be safe for concurrent use in separate
goroutines. Filters returned by lake.rangeWrapper.AsFilter do not have
this property because they share the single expr.ValueCompareFn in
rangeWrapper.compare. Fix this by creating a new expr.ValueCompareFn
for each filter returned.
Closes #2960.