Reset stateful expressions on EOS #5069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwt
reviewed
Mar 22, 2024
nwt
reviewed
Mar 22, 2024
mattnibs
force-pushed
the
reset-stateful
branch
from
d015b27 to
de4b911
Compare
mattnibs
force-pushed
the
reset-stateful
branch
from
de4b911 to
d756794
Compare
This commit fixes a bug where stateful expressions used in ops were not getting reset when the op encountered EOS. This would most notably result in unexpected values when using stateful expressions inside of lateral queries. Closes #4943
nwt
approved these changes
Jun 6, 2024
| arena *zed.Arena // For zed.Values created during compilation. | ||
| deletes *sync.Map | ||
| funcs map[string]expr.Function | ||
| resetters expr.Resetters |
There was a problem hiding this comment.
I think we might need an expr.Resetters stack here to handle stateful expressions nested at different levels correctly but this looks good for now.
There was a problem hiding this comment.
I think the one area for concern here is with over expressions. Everywhere else we just collect resetters for the expressions before recursing down into the flowgraph.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where stateful expressions were not getting reset when an op encounters EOS. This would most notably result in unexpected values when using stateful expressions inside of lateral queries.
Closes #4943
Closes #4937