-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework package sam/expr/coerce #5086
Conversation
Shout out to @nwt for doing the heavy lifting on this pr, I merely updated it and helped get it across the finish line. |
db5c4a9
to
42c0663
Compare
Rework the coerce package so that it uses native values instead of their byte representation.
We just discussed at a team meeting that I might add some automated tests based on the #4719 repro, so I'm happy to do that via a push to this branch or a separate PR if this merges first. In prep for that, I did some eyeballing of the output of this exhaustive run through math on all the numeric types:
On both tip of
Putting aside the fixes to the grossly incorrect math that appear at the bottom (which is all excellent improvement) I also can see that we're using the "bigger" types for math between other mixed types, e.g., the result of math between |
Rework the coerce package so that it uses native values instead of their byte representation.
Fixes #4719