Formatted String Literals #5123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattnibs
force-pushed
the
f-strings
branch
3 times, most recently
from
30065a7 to
4cb17a4
Compare
philrz
reviewed
May 14, 2024
philrz
reviewed
May 14, 2024
nwt
reviewed
May 24, 2024
There was a problem hiding this comment.
parser.peg at eb58396 is broken for me. Is it broken for you as well?
$ make -C compiler/parser
/Users/noah/brimdata/zed/compiler/parser/deps/bin/pigeon -support-left-recursion -o parser.go parser.peg
format error: filename:15114:53: missing ',' before newline in argument list (and 10 more errors)
make: *** [parser.go] Error 6
You are right! Will fix... |
nwt
force-pushed
the
positional-sem-errors
branch
2 times, most recently
from
e8f887c to
0adda42
Compare
mattnibs
force-pushed
the
positional-sem-errors
branch
3 times, most recently
from
6a7a54b to
280ebf1
Compare
nwt
approved these changes
May 31, 2024
after fixing those last few typos.
The commit removes the template literals and replaces them with formatted string literals. F-strings have a similar functionality but the expression substitution only happens on strings prefixed with the 'f' character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit removes the template literals and replaces them with formatted string literals. F-strings have a similar functionality but the expression substitution only happens on strings prefixed with the 'f' character.
Fixes #4444