Make the "this" example in user-defined op docs more explicit #5179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a community Slack thread, a user reported some struggles writing their first user-defined operator. In their own words:
After a little back & forth, we established that the minimal change of showing an explicit
yield this
instead ofpass
would have done the trick for him.FWIW, in my usual slightly-more-verbose way, my first proposal was:
However, the user said that he was fine with either. Since the team members here tend to prefer examples that lean toward the minimal, that's what I'm proposing in the PR. But if folks actually prefer my other idea, I'm happy to go that way too. 😉