Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output operator #5191

Merged
merged 1 commit into from
Aug 6, 2024
Merged

output operator #5191

merged 1 commit into from
Aug 6, 2024

Conversation

mattnibs
Copy link
Collaborator

Add output operator which allows users to set the name of the resultant channel. Channels are no longer identified by an integer but instead with a string- if a channel doesn't not have an output it will be assigned to channel "main".

@mattnibs mattnibs marked this pull request as ready for review July 22, 2024 22:48
@mattnibs mattnibs requested a review from a team July 22, 2024 22:48
@mattnibs mattnibs changed the base branch from main to describe-scope July 22, 2024 22:59
Base automatically changed from describe-scope to main July 25, 2024 18:23
@mattnibs mattnibs force-pushed the output-op branch 2 times, most recently from dc6d635 to 9c3da8b Compare July 29, 2024 18:21
compiler/kernel/op.go Outdated Show resolved Hide resolved
compiler/parser/parser.peg Outdated Show resolved Hide resolved
compiler/ast/dag/op.go Outdated Show resolved Hide resolved
compiler/job.go Outdated Show resolved Hide resolved
Copy link
Member

@nwt nwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before you merge, have we verified that this doesn't break Zui?

@mattnibs
Copy link
Collaborator Author

mattnibs commented Aug 6, 2024

@nwt no I will test this before mergin'

Add output operator which allows users to set the name of the resultant
channel. Channels are no longer identified by an integer but instead
with a string- if a channel doesn't not have an output it will be
assigned to channel "main".
@mattnibs mattnibs merged commit 343ac63 into main Aug 6, 2024
3 checks passed
@mattnibs mattnibs deleted the output-op branch August 6, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants