Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "by" examples to aggregate function docs, plus a few more fixes #5218

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

philrz
Copy link
Contributor

@philrz philrz commented Aug 13, 2024

What's Changing

This adds group-by examples to all the aggregate function docs that were missing them.

As I was going through all the pages, I fixed a couple things along the way and added a bonus dcount() example.

Why

In a recent community Slack thread, a user needed some guidance on the proper use of by. He noted that by examples on each aggregate function pages may have helped him figure it out on his own, which makes sense.

Details

While by is mentioned in the summarize operator page (and I'm proposing more improvements there via #5216) I suspect that new users may be more likely to land on the individual aggregate function pages first since they may do searches or follow links to them after seeing references to them in programs as they usually appear without summarize.

@philrz philrz requested a review from a team August 13, 2024 17:58
@philrz philrz self-assigned this Aug 13, 2024
@philrz philrz merged commit d90a2c1 into main Aug 16, 2024
4 checks passed
@philrz philrz deleted the more-by-examples branch August 16, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants