Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link to Avro spec #5244

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Fix broken link to Avro spec #5244

merged 1 commit into from
Aug 22, 2024

Conversation

philrz
Copy link
Contributor

@philrz philrz commented Aug 22, 2024

What's Changing

Fixing a broken link to the Avro site.

Why

The CI link checker spotted it when I put up unrelated changes in #5243.

Details

It looks like the Avro site may be mid-overhaul and I suspect they might make more changes before the dust settles. The "specs" that were at the old link are now at a URL of the format https://avro.apache.org/docs/1.12.0/specification/ with a locked-in version string, and current or latest doesn't work when I try it in place of the 1.12.0. Meanwhile they do have a selection called ++version++ in their left-hand nav such that the URL https://avro.apache.org/docs/++version++/specification/ does work and I suspect that's their equivalent of "current" now. But that looks ugly enough that I suspect if we start linking to it, they might well break it again if they find a way to put current or latest there instead.

Meanwhile, our ZNG format doc also happens to link to Avro but in that case it just points to the top-level site, so in the interest of simplicity I've just proposed doing the same here. 🤪

@philrz philrz requested a review from a team August 22, 2024 18:40
@philrz philrz self-assigned this Aug 22, 2024
@philrz philrz merged commit b9388c4 into main Aug 22, 2024
4 checks passed
@philrz philrz deleted the avro-link-fix branch August 22, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants