Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent packing of native modules #2917

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Prevent packing of native modules #2917

merged 1 commit into from
Dec 5, 2023

Conversation

philrz
Copy link
Contributor

@philrz philrz commented Dec 1, 2023

#2914 has the background and repro. The change in this PR is based on what I found in element-hq/element-web#17188 and how they fixed it via https://github.com/vector-im/element-desktop/pull/337/files, since their symptom looks exactly like ours.

I made a Dev build https://github.com/brimdata/zui/actions/runs/7064639612 using the change on this branch and it tested out fine. I used it to repeat the same repro steps shown in the video in #2914 (comment) and none of the .org.chromium.Chromium.* accumulated this time. The app also ran otherwise healthy, and in particular, I was able to import/query data, which is a sign that node-pipe (one of the modules now subject to different packaging) was still working fine, since it's my understanding that the successful launch of the zed serve process is dependent on that.

On my Linux VM I also did a find of the contents below /opt/Zui/resources with GA Zui v1.4.1 and then also with the Dev build just to confirm I saw only the expected differences, and that does seem to be the case.

$ diff 1.4.1.find devbuild.find
742a743,751
> app.asar.unpacked/node_modules
> app.asar.unpacked/node_modules/node-pipe
> app.asar.unpacked/node_modules/node-pipe/build
> app.asar.unpacked/node_modules/node-pipe/build/Release
> app.asar.unpacked/node_modules/node-pipe/build/Release/pipe.node
> app.asar.unpacked/node_modules/keytar
> app.asar.unpacked/node_modules/keytar/build
> app.asar.unpacked/node_modules/keytar/build/Release
> app.asar.unpacked/node_modules/keytar/build/Release/keytar.node

Fixes #2914

@philrz philrz requested review from nwt and jameskerr December 1, 2023 21:02
@philrz philrz self-assigned this Dec 1, 2023
@philrz philrz merged commit 288bb82 into main Dec 5, 2023
6 checks passed
@philrz philrz deleted the dont-pack-native-modules branch December 5, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creation of chromium binaries in /tmp/
2 participants