Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bugs Discovered by Steve #2996

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Fix Bugs Discovered by Steve #2996

merged 3 commits into from
Feb 7, 2024

Conversation

jameskerr
Copy link
Member

@jameskerr jameskerr commented Feb 5, 2024

  1. Fix presentation of null record types.
  2. Properly abort queries.
  3. Provide shallow copies of objects in the collect callback.

Details

We were not catching the abort error properly when issuing a query before the previous query finished.

We also were not aborting all of the histogram queries when re-issuing a search.

This stuff is really hard to write tests for. There are no tests in this PR. 🤷‍♂️

To test this, re-issue the search with a large pool over and over again rapidly. Open the network tab and view all the in-flight requests properly cancelling when a new search is issued.

Fixes #2997
Fixes #2999
Fixes #2838

@jameskerr jameskerr requested a review from philrz February 6, 2024 00:35
@jameskerr jameskerr changed the title Return Shallow Copies of Rows Fix Bugs Discovered by Steve Feb 6, 2024
@jameskerr jameskerr requested a review from mccanne February 6, 2024 00:41
Copy link
Contributor

@philrz philrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spent some time circling back to reproduce the original symptoms and captured those in #2997 and #2999, then tested this branch at commit 668f78d and the problems do indeed seem to be fixed. Therefore I'm 👍 on this.

@jameskerr jameskerr merged commit 67797fd into main Feb 7, 2024
3 checks passed
@jameskerr jameskerr deleted the shallow-copy-rows branch February 7, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants