-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Net Fetch in Electron #3069
Net Fetch in Electron #3069
Changes from 10 commits
3de0f5b
894cd72
8392dbf
16c48d3
8b8817c
f08a717
e8a3b8c
20425ae
9aca504
78880ad
2b926a9
404496f
6626d66
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import {Client} from "@brimdata/zed-node" | ||
import {net} from "electron" | ||
|
||
export class ElectronZedClient extends Client { | ||
fetch = | ||
process.env.JEST_WORKER_ID === undefined ? net.fetch : globalThis.fetch | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I mentioned in a previous comment that despite the app functionality and e2e tests working ok after the changes thus far, we were still seeing many failures during
Based on my understanding, these Jest tests are more lightweight so I assume the root cause is that Electron stuff like
This comment was marked as resolved.
Sorry, something went wrong. |
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import {Lake} from "@brimdata/zed-node" | ||
import {net} from "electron" | ||
|
||
export class ElectronZedLake extends Lake { | ||
fetch = | ||
process.env.JEST_WORKER_ID === undefined ? net.fetch : globalThis.fetch | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This loosens up the eslint rules so I can @ts-ignore and use
any
type.