Pin Playwright dependencies to 1.44.0 #3070
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem that I've determined via binary search showed up at commit 4b851d8 that's associated with the changes in #2972.
Starting at that commit, when locally running
yarn test
, I'm finding it only gets this far and then hangs:At that point a tab opens up on my browser to http://localhost:9323/ that looks like this:
If I click the top error it expands to:
Meanwhile the directory in question contains:
I don't claim to fully understand how this all fits together, but looking at what changed in #2972, I have a good guess. Before #2972 merged, zui-player was the only package that referenced Playwright:
But with the arrival of those changes, there's now a Playwright reference in the zed-wasm dependencies.
However, it looks like the absence of the
playwright-chromium
dependency meant that when trying to run the zed-wasm test it looked for a Chromium version associated with@playwright/test": "^1.40.1
and that's not the one provided by"playwright-chromium": "1.41.1"
.I confirmed that if I added the missing
1.40.1
entries to zed-wasm'spackage.json
it adds the additional Chromium version:...and
yarn test
passes.However, I also noticed that Playwright 1.44.0 has just come out and since there's no compelling reason to have the different packages depending on different Playwright versions I've converged everything here and confirmed that all tests still pass.