Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output union values in Detail panel/window #3103

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

philrz
Copy link
Contributor

@philrz philrz commented Jun 18, 2024

Since my approach in #3099 passed muster, that made me recall another open, union-centric issue #2938. Sure enough, as shown in the attached video, it seems a similar small change allows these union values to start being output where they weren't before.

Demo.mp4

Fixes #2938

@philrz philrz requested a review from jameskerr June 18, 2024 22:04
@philrz philrz self-assigned this Jun 18, 2024
Copy link
Member

@jameskerr jameskerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. I wonder if the logic to should be moved inside the "field" object. Something to consider. But I'll approve this.

@philrz philrz merged commit 52b4b58 into main Jun 18, 2024
4 checks passed
@philrz philrz deleted the union-vals-in-detail branch June 18, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zed union values rendered blank in Detail window
2 participants