Enable creation of release assets #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwt
reviewed
Jun 3, 2024
Co-authored-by: Noah Treuhaft <noah.treuhaft@gmail.com>
Co-authored-by: Noah Treuhaft <noah.treuhaft@gmail.com>
|
@nwt: I accepted your suggested changes, mirrored them into my personal fork at https://github.com/philrz/zync , made a test release v0.10.0, and successfully installed it via |
nwt
reviewed
Jun 4, 2024
Co-authored-by: Noah Treuhaft <noah.treuhaft@gmail.com>
goreleaser trims any "v" prefix from .Version but we want to keep it. .Summary is equivalent to "git describe --always --dirty --tags" so it includes the "v" prefix.
nwt
approved these changes
Jun 4, 2024
|
As a final test after that last commit from @nwt, I repeated the creation of a tagged release on my fork repo. The version string now appears as expected: The same was also true on Linux and macOS (both the unpacked artifact from the GitHub Releases and the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently had a request from a community user to have Windows binaries of
zyncavailable so they could run it without having to install Go and compile the code on their workstation. To provide this, here I've enabled the same approach we use in the Zed repo for creating tagged release assets, which in this case would allow the user to download and unpack the ZIP on their Windows system and copy thezync.exeto a folder that's in theirPATH.I've tested out the approach in this branch in a personal fork https://github.com/philrz/zync and you can see the successfully-created artifacts in https://github.com/philrz/zync/releases. As a smoke test I did unzip the Windows bundle and was able to successfully invoke the
zync.exe. I also went ahead and made a fork of our Homebrew repo at https://github.com/philrz/homebrew-tap and you can see the zync formula populated ok there as well.One thing I'll point out is that my artifact from the personal fork does not return a proper version string.
I suspect this problem may not show up when we create artifacts in the true zync repo, since we have a very similar known problem with Zed in personal forks (brimdata/super#4921). However, this whole topic of how the version strings get assembled has always been a little mysterious to me so I figured I'd point it out in case it concerns anyone enough that they want to dig deeper before merging this.