-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add urlsafe #357
feat: add urlsafe #357
Conversation
and this update makes crypto doesn't work on ie11 |
Are you sure it is affected by this pr? Can you provide some information? If it is determined that it is affected by pr, you can delete this method if you don't need url-safe. @kylelieTomo |
yes, ie11 doesn't support default value on params. and the "urlSafe=true" affect ie |
Maybe this repo does not configure the corresponding babel, you can clone in the past and configure the corresponding babel yourself |
@kylelieTomo, were you able to get this working in IE 11? |
no, i just fall back to 4.0.0 |
@spencer17x, do you have any plans to resolve this? Permanently falling back to an old version isn't ideal as consumers wouldn't be able to get new security fixes in future versions. |
@trmpowell The author of this library is not me. If I fix it, I need to mention pr. I am not sure when the author will merge. If you need it, I can fork it and maintain it. |
@trmpowell Hello, I used this pr to fix the problem you raised, but I need to wait for the author to merge, and I may fork this repo and use other build tools to maintain it in the future. |
Thanks, @spencer17x! No problem on needing to wait for the repo owner to merge. That is expected. 😃 |
Android |
Wifi |
issue:#252