Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add urlsafe #357

Merged
merged 1 commit into from
Jul 22, 2021
Merged

feat: add urlsafe #357

merged 1 commit into from
Jul 22, 2021

Conversation

spencer17x
Copy link
Contributor

issue:#252

@evanvosberg evanvosberg merged commit aa9a708 into brix:develop Jul 22, 2021
@kylelieTomo
Copy link

and this update makes crypto doesn't work on ie11

@spencer17x
Copy link
Contributor Author

Are you sure it is affected by this pr? Can you provide some information? If it is determined that it is affected by pr, you can delete this method if you don't need url-safe. @kylelieTomo

@kylelieTomo
Copy link

kylelieTomo commented Jul 29, 2021

yes, ie11 doesn't support default value on params. and the "urlSafe=true" affect ie

@spencer17x
Copy link
Contributor Author

Maybe this repo does not configure the corresponding babel, you can clone in the past and configure the corresponding babel yourself

@trmpowell
Copy link

@kylelieTomo, were you able to get this working in IE 11?

@kylelieTomo
Copy link

@kylelieTomo, were you able to get this working in IE 11?

no, i just fall back to 4.0.0

@trmpowell
Copy link

@spencer17x, do you have any plans to resolve this? Permanently falling back to an old version isn't ideal as consumers wouldn't be able to get new security fixes in future versions.

@spencer17x
Copy link
Contributor Author

@trmpowell The author of this library is not me. If I fix it, I need to mention pr. I am not sure when the author will merge. If you need it, I can fork it and maintain it.

@spencer17x
Copy link
Contributor Author

spencer17x commented Aug 17, 2021

@trmpowell Hello, I used this pr to fix the problem you raised, but I need to wait for the author to merge, and I may fork this repo and use other build tools to maintain it in the future.

@trmpowell
Copy link

Thanks, @spencer17x! No problem on needing to wait for the repo owner to merge. That is expected. 😃

spencer17x added a commit to spencer17x/crypto-js that referenced this pull request Sep 1, 2021
@Mehmdsed
Copy link

Mehmdsed commented Jan 6, 2024

Android

@Mehmdsed
Copy link

Mehmdsed commented Jan 6, 2024

Wifi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants