Skip to content

Commit

Permalink
Avoid out-of-bounds write in graph_append function
Browse files Browse the repository at this point in the history
Retrieve graph only when s->graph is already allocated, which also mens
that the s->graph_width is bigger than 0, and thus avoid out-of-bounds
write in graph_append function.

Prior to 594d0c8 ("Fix bug of "Graph reset when using conditional
color"") s->graph was not (re)allocated when s->graph_width and
s->graph_allocated were equal to zero, therefore, s->graph stayed equal
to nullptr. This effectively meant that graph_append function returned
immediately after call and did nothing.

This behavior changed with introduction of std::map<int, double *> graphs,
because its retrieve_graph support function allocates s->graph even for
s->graph_width equal to 0. Then, subsequent call of graph_append can
continue and the first element of the graph is set later in this
function in line:

  graph->graph[0] = f; /* add new data */

causing out-of-bounds write, as there is not enough space in array of
zero length. This write messes up internal data of memory allocator (at
least in musl libc case) and the application later segfaults in attempt
to free this memory in store_graph function.

Fixes: 594d0c8 ("Fix bug of "Graph reset when using conditional color"")
  • Loading branch information
arkamar authored and brndnmtthws committed Aug 26, 2022
1 parent 18d5aeb commit f90f632
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/specials.cc
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ void new_graph(struct text_object *obj, char *buf, int buf_max_size,
}
#endif

s->graph = retrieve_graph(g->id, s->graph_width);
if (s->graph) { s->graph = retrieve_graph(g->id, s->graph_width); }

graph_append(s, val, g->flags);

Expand Down

0 comments on commit f90f632

Please sign in to comment.