Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvidia percentages don't get a padding with config pad_percents #1165

Closed
kistlin opened this issue Jan 10, 2022 · 0 comments · Fixed by #1166
Closed

nvidia percentages don't get a padding with config pad_percents #1165

kistlin opened this issue Jan 10, 2022 · 0 comments · Fixed by #1166

Comments

@kistlin
Copy link
Contributor

kistlin commented Jan 10, 2022

Issue

nvidia print callbacks are registered as print callbacks obj->callbacks.print = &print_nvidia_value; (line 1869, src/core.cc).

And in src/conky.cc (line 722)

    if (obj->callbacks.print != nullptr) {
      (*obj->callbacks.print)(obj, p, p_max_size);

the callbacks are called.

For percentages to be printed correctly we would need to call (line 722, src/conky.cc), using callbacks.percentage.

    } else if (obj->callbacks.percentage != nullptr) {
      percent_print(p, p_max_size, (*obj->callbacks.percentage)(obj));
    }

Information

Source version at the time of writing 8f5014b9.

kistlin added a commit to kistlin/conky that referenced this issue Jan 10, 2022
brndnmtthws pushed a commit that referenced this issue Sep 13, 2022
clrpackages pushed a commit to clearlinux-pkgs/conky that referenced this issue Dec 28, 2022
…16.1

Brenden Matthews (129):
      Bump version for next release.
      Update OS/compilers.
      Take 2.
      No clang 9.
      No clang 15 (yet).
      Only install libc++ for clang.
      Add missing dbus-glib.
      Remove deprecated rsvg_handle_render_cairo_sub, add
      Remove deprecated rsvg_handle_render_cairo, add
      Remove deprecated rsvg_handle_get_dimensions, add
      rsvg_handle_get_intrinsic_size_in_pixels only available on librsvg 2.52
      Don't include version header directly.
      Comment out rsvg_handle_get_intrinsic_size_in_pixels for now.
      Require librsvg >=2.52.
      Docker: bump cmake, disable librsvg bindings.
      Disable librsvg on ubuntu 20.04.
      Switch docker base to jammy (it's lts), reenable librsvg.
      Run appimage build on 22.04.
      Add missing dbus-glib dep.
      Add missing libfuse2 for appimage.
      Update buildx actions.
      Add missing docker build deps.
      Bump version.
      Drop gitlab CI.
      Update release action.
      Add sha256sum for appimage artifact.
      Use proper names for artifacts.
      Fix names here too.
      Check display before free.
      Bump version.
      Switch release discussion category.
      Some fonts might treat spaces as 0 width.
      This does nothing.
      Update README.md
      This should be max, not min.
      Refactor docs, make a new website.
      Add a bit of documentation about the docs.
      Refactor doc component, update doc docs.
      Adjust fonts.
      wip
      Doc fixes, remove cmake docbook stuff.
      Add nav thing, fix fonts, docs.
      Refactor docs.
      Add labeler workflow.
      Fix labeler path.
      Add fuzzy search to web docs.
      Add search keyboard shortcut.
      Only close dialogue after selection.
      Make search transitions less annoying.
      Fix action name, sync labels.
      Improve search index, index page, add wiki link.
      Update README.md
      Update PR and issue templates.
      Add the new files, derp.
      Fix the words.
      Reformat.
      Reformat.
      Require this field.
      Move this back to the previous path.
      Adjust layout for docs.
      Adjust border colour.
      Close stale issues/PRs after 1 year.
      Set stale workflow permissions, prune branches.
      Simplify PR template.
      Fix stale messages.
      Add note about optional args.
      Update extras (syntax files) w/ new docs.
      Include the doc dir in netlify build.ignore.
      Fix a bunch of doc formatting issues.
      Adjust colors/format for web docs.
      Fix stale comment wording.
      Allow meta + K shortcut for search, use npm not yarn.
      Optimize static props a bit.
      Bump netlify plugin.
      Update README.md
      Add 404 page, fix fonts.
      Typo.
      Minor doc fixes.
      Update labeler.yml
      Print build commands in CI.
      Add label for actions.
      Run `npm update --save`.
      More doc fixes.
      Fix table formatting.
      Update PR template.
      Drop unimplemented weather code.
      Need to enable curl for RSS.
      Bump according to semver rules.
      Bump again according to semver rules.
      Run clang-format.
      Don't reformat catch2 with `make clang-format`.
      Cancel previous concurrent build actions.
      Create dependabot.yml
      Add man page to releases.
      Drop docbook from build deps.
      Separate docs & extras (syntax files) build.
      Enable dependabot for web docs.
      Add copyleft just for funsies.
      Gzip the man page.
      Fix create/destroy/set/get Lua Rsvg functions.
      Bump version for next release.
      Bump version for next release.
      Fix dates in man page.
      Update Lua cairo bindings.
      Bump web deps.
      Bump web deps.
      Change assert in set_font to check w/ debug.
      Tidy a couple things.
      Apply clang-format.
      Fix some include ordering/build stuff.
      Bump web deps.
      Build fixes for newly introduced Wayland support.
      Bump version.
      Bump version.
      Use clang for appimage build.
      Better release note generation, for next release.
      Add missing unistd include.
      Use ninja instead of make in build.
      Fix package name.
      Fix this install command fail.
      Try it this way instead.
      Put the code coverage stuff behind a build flag.
      Default wayland build to off.
      Fix (some) wayland/x11 init ordering issues.
      Add this back.
      This is superfluous.
      Fix missing settings fail.
      Drop this message.
      Use the cmake commands here instead. (#1346)

Caio Freitas de Oliveira (16):
      use LCh color space (Rec.2020 for luma)
      explicit L
      use clang-format
      fix decimal conversions
      restore hsv_gradient
      restore tests
      refactor gradients to use config value instead of hard-coded option
      remove hsv_gradient
      PR changes; fix saturation calculation (scale before dividing)
      fix docs
      fix delete abstract with non-virtual dtor
      fix unused parameter
      fix undeclared identifier
      use shift for masks; fix tests for 16-bit color depth
      add special case for X11 tests
      remove include

Chaitanya Kukde (2):
      Fixes #1068 : Add cmake uninstall target
      Add License information to cmake uninstall source

François Revol (28):
      Add a BUILD_GUI define (for now only defined on BUILD_X11)
      Make out_to_stderr setting non-static
      Initial stubbing of display backends
      Move HTTP output code from conky.cc to display-http
      Actually allow more than one display-output at once
      Make sure the console output isn't enabled along with ncurses
      Add a display-output flag to tell if it's graphical-based
      Initial ncurses display-output
      http display: use lower priority than graphical displays
      Replace BUILD_X11 ifdef by BUILD_GUI when it makes sense
      display-*: Fix copyright
      display-*: return void for most calls as return-value is useless
      proper console display (move code out of conky.cc)
      add display accessors
      move file output to a separate display-file
      move X11 stuff from conky.cc to display-x11
      Move X11 font stuff to display-x11
      display: fix logging
      Update copyright, authors.
      Fix warnings
      Work around linker missing objects when building tests
      Fix crash when no display output is enabled
      Add TODO for the gui-backends branch
      Add an http_port config setting
      Add syntax keyword for http_port config setting
      Reset selected_font after drawing shades/outline
      X11 cleanup: out_to_x -> display_output()->graphical()
      X11 cleanup: Some more obvious BUILD_X11 -> BUILD_GUI

Gene Carlson (10):
      Linux: enable displaying shmem and memavail as variables.
      Linux: add a variable free_bufcache for reporting buffers+cache as reported by free.
      Linux: show the scaling governor with $cpugovernor.
      Use strtol in preference to atoi for cpugovernor.
      core.cc: Remove a redundant condition for cpugovernor.
      Replace atoi and atol with strtol (most files).
      Fix man page formatting.
      FreeBSD: Additional memory reporting variables.
      src/common.cc: Fix accidental whitespace change
      docs/variables.yaml: A better description for memlaundry.

Guido Falsi (2):
      Avoid referencing underfined symbol
      Implement get_battery_power_draw() for FreeBSD.

Johannes Halaoui (1):
      Add an option to disable storing graph data explicitly

Marius Feraru (1):
      add units_spacer option for tuning string between values and units

Miroslav Lichvar (1):
      Include hsv_gradient.h even if BUILTIN_CONFIG is disabled.

Petr Vaněk (3):
      Access graph id through g->id
      Avoid out-of-bounds write in graph_append function
      Correct dependencies on generated header files

Rafał Lalik (4):
      Use cmake macros for cxx standards
      Detect that nvidia display exists in each refresh
      Fix ternary operator bug with implicit true value assignment
      Fix releasing of nv displays

Steven Xu (2):
      feat: make `gw_iface` work with `downspeedgraph` & `upspeedgraph`, e.g. `${downspeedgraph ${gw_iface}}`
      feat: make `gw_iface` work with `downspeed` & `upspeed`, e.g. `${downspeed ${gw_iface}}`

bi4k8 (25):
      linux: remove nonsensical ip_addr loop break cond
      build, colours, core, gui, wayland, wl, x11: implement wayland display backend
      wl: declare desktop/monitor info functions as weak symbols
      wayland: implement buffer scaling
      wayland: switch to zwlr_layer_shell_v1 and implement proper window placement
      colours: parse X11 colors under Wayland
      colours: define manually_get_x11_color for usage outside X11
      wayland: fix crash after 5 minutes
      wayland: respond to xdg_wm_base.ping
      wayland: rework window destruction/resizing
      config: add out_to_wayland to bool setting list for config converter
      doc: document out_to_wayland setting
      core: fix right-alignment with wayland
      core: fix segfault when no display outputs are enabled
      core: fix misbehavior in specials handling that fails badly with Wayland backend
      x11, gui: update display-x11.cc to account for some code moved into gui.h/gui.cc
      gui: remove background_color from gui.cc and window_type/window_hints from gui.h
      x11: update x11.cc for functionality moved into gui.cc
      x11, imlib2: early-exit in some X functions if X is not available at runtime
      x11: early-return from use_xdbe_setting::set_up if X11 not initialized
      x11: do not treat init failure as fatal with Wayland
      ci: update for Wayland build
      wayland: clamp text width
      wayland: permit unused parameters
      build: add pangoft2 to Wayland deps

brightkill (4):
      added option battery_power_draw to get power draw in watts
      added changes to manpage
      added get_battery_power_draw() stub for darwin
      fix bug when conky displays zero values after time

crolsma (1):
      Document unimplemented weather features

dependabot[bot] (25):
      Bump actions/checkout from 2 to 3
      Bump postcss from 8.4.17 to 8.4.18 in /web
      Bump @netlify/plugin-nextjs from 4.24.3 to 4.25.0 in /web
      Bump @types/node from 18.8.3 to 18.8.5 in /web
      Bump cypress from 10.9.0 to 10.10.0 in /web
      Bump @netlify/plugin-nextjs from 4.25.0 to 4.26.0 in /web
      Bump @types/node from 18.8.5 to 18.11.0 in /web
      Bump @fontsource/inter from 4.5.13 to 4.5.14 in /web
      Bump @fontsource/newsreader from 4.5.8 to 4.5.9 in /web
      Bump @types/node from 18.11.0 to 18.11.4 in /web
      Bump tailwindcss from 3.1.8 to 3.2.1 in /web
      Bump @types/react from 18.0.21 to 18.0.22 in /web
      Bump eslint from 8.25.0 to 8.26.0 in /web
      Bump @netlify/plugin-nextjs from 4.26.0 to 4.27.3 in /web
      Bump next from 12.3.1 to 13.0.0 in /web
      Bump @netlify/plugin-nextjs from 4.27.3 to 4.28.3 in /web
      Bump autoprefixer from 10.4.12 to 10.4.13 in /web
      Bump eslint-config-next from 12.3.1 to 13.0.0 in /web
      Bump cypress from 10.10.0 to 10.11.0 in /web
      Bump eslint from 8.26.0 to 8.27.0 in /web
      Bump next from 13.0.0 to 13.0.2 in /web
      Bump @netlify/plugin-nextjs from 4.28.3 to 4.28.5 in /web
      Bump @tailwindcss/typography from 0.5.7 to 0.5.8 in /web
      Bump eslint-config-next from 13.0.0 to 13.0.2 in /web
      build(deps): bump actions/stale from 6 to 7

dessert1 (1):
      fix typo in in lua_parse description

kistlin (1):
      possible fix for brndnmtthws/conky#1165

missing-semi-colon (1):
      Fix diskio graph scale being 3 orders of magnitude too small
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant