Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid referencing underfined symbol #1220

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Avoid referencing underfined symbol #1220

merged 1 commit into from
Sep 20, 2022

Conversation

madpilot78
Copy link
Contributor

When building without ncurses out_to_ncurses is not defined. It is also not needed to check for ncurses if it is not compiled in.

The error I'm getting when building without ncurses is:

--- src/CMakeFiles/conky.dir/display-console.cc.o ---
/wrkdirs/usr/ports/sysutils/conky/work/conky-1.13.1/src/display-console.cc:58:8: error: use of undeclared identifier 'out_to_ncurses'
      !out_to_ncurses.get(*state)) {
       ^
1 error generated.
*** [src/CMakeFiles/conky.dir/display-console.cc.o] Error code 1

When building without ncurses out_to_ncurses is not defined. It is also not needed to check for ncurses if it is not compiled in.
@brndnmtthws brndnmtthws merged commit 65890ea into brndnmtthws:main Sep 20, 2022
@madpilot78 madpilot78 deleted the Fix_Build_Without_NCurses branch September 20, 2022 13:47
@mmuman
Copy link
Collaborator

mmuman commented Sep 20, 2022

Thanks, I didn't try all combinations 😅

@madpilot78
Copy link
Contributor Author

Thanks, I didn't try all combinations sweat_smile

I did, but just because I was updating the FreeBSD port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants