use new Colour type for specials and gradients #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 23, 2023 01:41
our Colour type assumes this anyway; lower colour depth should be handled by display backends
this was mistakenly disabled when moving to a unified Colour representation
✅ Deploy Preview for conkyweb canceled.
|
github-actions
bot
added
sources
added 3 commits
February 23, 2023 01:47
colour computations no longer depend on the display backends we compile with, so these can be tested unconditionally now
this makes specials now accept color names as well as hex codes, and removes all notions of color depth from gradient calculations
bi4k8
force-pushed
the
color-type-specials
branch
from
e091ae6
to
fbfd90e
Compare
brndnmtthws
approved these changes
Feb 24, 2023
simotek
pushed a commit
to simotek/conky
that referenced
this pull request
Apr 5, 2023
* gradient, colours: use 24-bit colour depth internally on Wayland our Colour type assumes this anyway; lower colour depth should be handled by display backends * core: restore gradient color computation this was mistakenly disabled when moving to a unified Colour representation * core, gradient: use Colour type * tests: gradient: always test hsv/hcl colour computations no longer depend on the display backends we compile with, so these can be tested unconditionally now * gradients, specials: use Color type this makes specials now accept color names as well as hex codes, and removes all notions of color depth from gradient calculations --------- Co-authored-by: bi4k8 <bi4k8@github>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1417 and #1411.
Checklist
doc/has been updatedDescription
This reinstates the gradient code that I forgot I'd commented out when introducing the pervasive
Colourtype, and translates nearby code (in specials and gradients) to use it. This simplifies a lot, removes hairy bit-masking and colour depth dependence, as well as dependencies on config and output initialization while computing special and gradient colors. It also makes it possible to use colour names like "red" in graphs, instead of only hex ones, as well as "#ffccaa" syntax with a pound sign (which was forbidden previously). This also enables running more of the gradient tests even in the compile-time absence of X11.I tested visual appearance of graphs on a Wayland build using the config file from the upstream debian bug, as well as running
ninja test.