Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display-output: allow no outputs #1481

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

bi4k8
Copy link
Collaborator

@bi4k8 bi4k8 commented Mar 31, 2023

Some users rely on this behavior, which quietly changed in 281097a.

Fixes #1479.

Checklist

  • I have described the changes
  • I have linked to any relevant GitHub issues, if applicable
  • [n/a] Documentation in doc/ has been updated
  • All new code is licensed under GPLv3

Description

This restores the old behavior prior to 281097a: we warn but do not exit when no display outputs are specified.

some users rely on this behavior, which quietly changed in 281097a
@netlify
Copy link

netlify bot commented Mar 31, 2023

Deploy Preview for conkyweb ready!

Name Link
🔨 Latest commit 8d48726
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/642646238afd3800087eb9d5
😎 Deploy Preview https://deploy-preview-1481--conkyweb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the sources PR modifies project sources label Mar 31, 2023
@brndnmtthws brndnmtthws added the bug Bug report or bug fix PR label Mar 31, 2023
@brndnmtthws brndnmtthws merged commit 4a40eef into brndnmtthws:main Mar 31, 2023
@bi4k8 bi4k8 deleted the allow-no-outputs branch March 31, 2023 18:24
simotek pushed a commit to simotek/conky that referenced this pull request Apr 5, 2023
some users rely on this behavior, which quietly changed in 281097a

Co-authored-by: bi4k8 <bi4k8@github>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report or bug fix PR sources PR modifies project sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: out_to_x = false causes startup failure
2 participants