Add wlr layer shell check #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conkyweb canceled.
|
Print a nicer error message if the compositor doesn't support wlr-layer-shell-unstable-v1 spec. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
|
This needs to be tested. I don't have a WM without layer shell installed so I just made a quick PR as it was quicker than describing the change in the issue. |
brndnmtthws
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1751
When a global is registered with
wl_registry_add_listenerit receives events for all supported extensions in bulk.wl_display_roundtripcall blocks until the initial events are exchanged so it's safe to check whetherwl_globals.layer_shellis initialized right after that.