Define text_object.data.l as "long long" #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that text_object.data.l is at least 64 bits in size, even in a 32-bit environment. It can cause issues if smaller, such as text turning black instead of a desired color (see brndnmtthws#1477).
✅ Deploy Preview for conkyweb canceled.
|
|
I suggest using |
brndnmtthws
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/has been updatedDescription
The definition of
text_object.data.lis changed fromlongtolong long. In 32-bit environments,longmay be as short as 32 bits, and this can cause minor issues. Specifically, I was hitting #1477.This change solved the issue for me, and it doesn't appear to cause new issues, even on a 64-bit platform. However, it may not be the best fix in the long run, as
intandlong longare still platform-specific and can hide similar bugs.Fixed-size definitions (e.g.
uint64_t) should be safer, but I'm not sure what the sizes should be (the defaults on x86_64 could be a good starting point). I can update the PR if this solutions turns out to be preferred.