set_struts improvements #1849
Merged
set_struts improvements #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Caellian
force-pushed
the
dev/cleanup-globals
branch
5 times, most recently
from
cba15e6
to
8e07629
Compare
Caellian
force-pushed
the
dev/strut-improvements
branch
from
782b39b
to
f696db3
Compare
✅ Deploy Preview for conkyweb canceled.
|
Caellian
force-pushed
the
dev/strut-improvements
branch
4 times, most recently
from
5cdaf05
to
a452468
Compare
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Caellian
force-pushed
the
dev/strut-improvements
branch
from
a452468
to
a2df27a
Compare
Did this to abide by: A "corner" panel that does not extend for the full length of a screen border SHOULD only set one strut. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Caellian
force-pushed
the
dev/strut-improvements
branch
from
cb6adb7
to
87f21ca
Compare
|
@brndnmtthws Try re-running CI when you get to this, I tested it and it should work. CI is failing on package install for some reason. |
brndnmtthws
approved these changes
Apr 24, 2024
|
Seems to be a known issue, just need to wait for it to be resolved: https://www.githubstatus.com/incidents/7txcg0j03kkg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
set_strutsfunction to acceptalignmentdirectly instead of using an intermediate value.This commit makes code easier to follow and improves performance a tiny bit because it inlines a loop.
Testing
main, it's possible this is a bug in Openbox because set values seem fine.