Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DPI when changed in resource manager #1878

Merged
merged 4 commits into from
May 1, 2024
Merged

Update DPI when changed in resource manager #1878

merged 4 commits into from
May 1, 2024

Conversation

Caellian
Copy link
Collaborator

@Caellian Caellian commented May 1, 2024 •
edited
Loading

Description

This PR makes Xft dpi code use resource manager database to get the value, and updates the value on change in resource database. This closes #407.

Other changes

  • Added fallback when Xft isn't enabled.
  • Removed some guards which weren't needed anymore.
  • Made find_desktop_window, that is find_subwindow, be more specific which fixes [Bug]: Conky desktop selection not specific enough #1730.
  • Removed display width and height
    • They were used from a few places and weren't needed, they were also not a good fit for set_struts because workarea handles display offset properly.

Testing

  • Tested Xft.dpi listening and updates.
  • Tested changes to find_desktop_window don't break functionality (plasma, mate)

@Caellian
Update xft_dpi on property change
c5381b4 
- Added fallback calculation when Xft is disabled.
- Removed display_width/height and replaced it with workarea for
  consistency.

Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@github-actions github-actions bot added sources PR modifies project sources display: x11 Issue related to X11 backend labels May 1, 2024
@netlify Netlify
Copy link

netlify bot commented May 1, 2024 •
edited
Loading

✅ Deploy Preview for conkyweb canceled.

Name Link
🔨 Latest commit e61afe9
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/66318bec7ffba40008ffd76b

@Caellian
Update use of display size
9f8b955 
Simplifies code in case of find_subwindow, more correct in case of
set_struts.

Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@Caellian
Make DPI work when Xft is disabled
98b4145 
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@Caellian Caellian added enhancement Issue that suggests an enhancement rendering Issue or PR related to rendering labels May 1, 2024
@Caellian
Make find_subwindow more specific, rename it
e61afe9 
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@github-actions github-actions bot removed the rendering Issue or PR related to rendering label May 1, 2024
@Caellian Caellian added rendering Issue or PR related to rendering bug Bug report or bug fix PR labels May 1, 2024
@brndnmtthws brndnmtthws added the feature New feature PR or issue label May 1, 2024
@Caellian Caellian removed the enhancement Issue that suggests an enhancement label May 1, 2024
@Caellian Caellian merged commit 7b44b2a into main May 1, 2024
62 checks passed
@Caellian Caellian deleted the dev/update-dpi branch May 1, 2024 14:55
@Caellian Caellian mentioned this pull request May 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brndnmtthws brndnmtthws brndnmtthws approved these changes

Assignees
No one assigned
Labels
bug Bug report or bug fix PR display: x11 Issue related to X11 backend feature New feature PR or issue rendering Issue or PR related to rendering sources PR modifies project sources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Conky desktop selection not specific enough DPI issues
2 participants
@Caellian @brndnmtthws