Make dpi_scale match original behavior #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conkyweb canceled.
|
Caellian
force-pushed
the
fix/inconsistent-scaling
branch
from
56cf5c8
to
7728a4d
Compare
I arrived at previous solution because the original code used premultiplied values to round the result so I (incorrectly) assumed it was doing something akin to truncation. Also replaced SFINAE with static_assert - got really carried away with it previously because I believed it provided better type checking integration; but they're the same and errors look the same. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Caellian
force-pushed
the
fix/inconsistent-scaling
branch
from
7728a4d
to
e3fa42b
Compare
brndnmtthws
approved these changes
May 26, 2024
|
Merging without confirmation because (according to tests) the returned values match old behavior better, even if I don't know whether it fixes the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I arrived at previous solution because the original code used premultiplied values to round the result so I (incorrectly) assumed it was doing something akin to truncation.
Also replaced SFINAE with static_assert - got really carried away with it previously because I believed it provided better type checking integration; but they're the same and errors look the same.
Fixes #1930.