Skip to content

Commit

Permalink
PHP_CodeCoverage no longer uses YUI.
Browse files Browse the repository at this point in the history
  • Loading branch information
sebastianbergmann committed Sep 17, 2012
1 parent b960cd5 commit 336c3ed
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 16 deletions.
7 changes: 0 additions & 7 deletions PHPUnit/TextUI/TestRunner.php
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,6 @@ public function doRun(PHPUnit_Framework_Test $suite, array $arguments = array())
$writer = new PHP_CodeCoverage_Report_HTML(
$title,
$arguments['reportCharset'],
$arguments['reportYUI'],
$arguments['reportHighlight'],
$arguments['reportLowUpperBound'],
$arguments['reportHighLowerBound'],
Expand Down Expand Up @@ -640,11 +639,6 @@ protected function handleConfiguration(array &$arguments)
$arguments['reportCharset'] = $loggingConfiguration['charset'];
}

if (isset($loggingConfiguration['yui']) &&
!isset($arguments['reportYUI'])) {
$arguments['reportYUI'] = $loggingConfiguration['yui'];
}

if (isset($loggingConfiguration['highlight']) &&
!isset($arguments['reportHighlight'])) {
$arguments['reportHighlight'] = $loggingConfiguration['highlight'];
Expand Down Expand Up @@ -787,7 +781,6 @@ protected function handleConfiguration(array &$arguments)
$arguments['reportHighlight'] = isset($arguments['reportHighlight']) ? $arguments['reportHighlight'] : FALSE;
$arguments['reportHighLowerBound'] = isset($arguments['reportHighLowerBound']) ? $arguments['reportHighLowerBound'] : 70;
$arguments['reportLowUpperBound'] = isset($arguments['reportLowUpperBound']) ? $arguments['reportLowUpperBound'] : 35;
$arguments['reportYUI'] = isset($arguments['reportYUI']) ? $arguments['reportYUI'] : TRUE;
$arguments['stopOnError'] = isset($arguments['stopOnError']) ? $arguments['stopOnError'] : FALSE;
$arguments['stopOnFailure'] = isset($arguments['stopOnFailure']) ? $arguments['stopOnFailure'] : FALSE;
$arguments['stopOnIncomplete'] = isset($arguments['stopOnIncomplete']) ? $arguments['stopOnIncomplete'] : FALSE;
Expand Down
9 changes: 1 addition & 8 deletions PHPUnit/Util/Configuration.php
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@
*
* <logging>
* <log type="coverage-html" target="/tmp/report" title="My Project"
charset="UTF-8" yui="true" highlight="false"
charset="UTF-8" highlight="false"
* lowUpperBound="35" highLowerBound="70"/>
* <log type="coverage-clover" target="/tmp/clover.xml"/>
* <log type="json" target="/tmp/logfile.json"/>
Expand Down Expand Up @@ -404,13 +404,6 @@ public function getLoggingConfiguration()
$result['highLowerBound'] = (string)$log->getAttribute('highLowerBound');
}

if ($log->hasAttribute('yui')) {
$result['yui'] = $this->getBoolean(
(string)$log->getAttribute('yui'),
TRUE
);
}

if ($log->hasAttribute('highlight')) {
$result['highlight'] = $this->getBoolean(
(string)$log->getAttribute('highlight'),
Expand Down
1 change: 0 additions & 1 deletion Tests/Util/ConfigurationTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,6 @@ public function testLoggingConfigurationIsReadCorrectly()
'charset' => 'UTF-8',
'lowUpperBound' => '35',
'highLowerBound' => '70',
'yui' => TRUE,
'highlight' => FALSE,
'coverage-html' => '/tmp/report',
'coverage-clover' => '/tmp/clover.xml',
Expand Down

0 comments on commit 336c3ed

Please sign in to comment.