Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: nudge indenting of options in logging #436

Merged
merged 2 commits into from
Mar 16, 2021
Merged

refactor: nudge indenting of options in logging #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26e0288
refactor: nudge indenting of options in logging
brodycj Mar 16, 2021
d55ae8d
update test snapshot
brodycj Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions lib/lib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,25 +103,25 @@ const generateWithNormalizedOptions = ({
info(
`CREATE new React Native module with the following options:

name: ${name}
full package name: ${packageName}
is view: ${view}
object class name: ${objectClassName}
Android nativePackageId: ${nativePackageId}
platforms: ${platforms}
Apple tvosEnabled: ${tvosEnabled}
authorName: ${authorName}
authorEmail: ${authorEmail}
author githubAccount: ${githubAccount}
license: ${license}
useAppleNetworking: ${useAppleNetworking}
name: ${name}
full package name: ${packageName}
is view: ${view}
object class name: ${objectClassName}
Android nativePackageId: ${nativePackageId}
platforms: ${platforms}
Apple tvosEnabled: ${tvosEnabled}
authorName: ${authorName}
authorEmail: ${authorEmail}
author githubAccount: ${githubAccount}
license: ${license}
useAppleNetworking: ${useAppleNetworking}
` + (generateExample
? `
generateExample: ${generateExample}
exampleFileLinkage: ${exampleFileLinkage}
exampleName: ${exampleName}
exampleReactNativeTemplate: ${exampleReactNativeTemplate}
writeExamplePodfile: ${writeExamplePodfile}
generateExample: ${generateExample}
exampleFileLinkage: ${exampleFileLinkage}
exampleName: ${exampleName}
exampleReactNativeTemplate: ${exampleReactNativeTemplate}
writeExamplePodfile: ${writeExamplePodfile}
` : ``));

// QUICK LOCAL INJECTION overwite of existing execSync / commandSync call from
Expand Down
24 changes: 12 additions & 12 deletions ...gus-platforms/bogus-name/__snapshots__/cli-command-with-bogus-platforms-name.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,18 @@ Array [
"info": Array [
"CREATE new React Native module with the following options:

name: alice-bobbi
full package name: react-native-alice-bobbi
is view: false
object class name: AliceBobbi
Android nativePackageId: com.reactlibrary
platforms: bogus
Apple tvosEnabled: false
authorName: Your Name
authorEmail: yourname@email.com
author githubAccount: github_account
license: MIT
useAppleNetworking: false
name: alice-bobbi
full package name: react-native-alice-bobbi
is view: false
object class name: AliceBobbi
Android nativePackageId: com.reactlibrary
platforms: bogus
Apple tvosEnabled: false
authorName: Your Name
authorEmail: yourname@email.com
author githubAccount: github_account
license: MIT
useAppleNetworking: false
",
],
},
Expand Down
24 changes: 12 additions & 12 deletions ...platforms/empty-string/__snapshots__/cli-command-with-empty-platforms-string.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,18 @@ Array [
"info": Array [
"CREATE new React Native module with the following options:

name: alice-bobbi
full package name: react-native-alice-bobbi
is view: false
object class name: AliceBobbi
Android nativePackageId: com.reactlibrary
platforms:
Apple tvosEnabled: false
authorName: Your Name
authorEmail: yourname@email.com
author githubAccount: github_account
license: MIT
useAppleNetworking: false
name: alice-bobbi
full package name: react-native-alice-bobbi
is view: false
object class name: AliceBobbi
Android nativePackageId: com.reactlibrary
platforms:
Apple tvosEnabled: false
authorName: Your Name
authorEmail: yourname@email.com
author githubAccount: github_account
license: MIT
useAppleNetworking: false
",
],
},
Expand Down
24 changes: 12 additions & 12 deletions ...nc/with-logging/with-error/__snapshots__/cli-command-with-logging-with-error.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,18 @@ Array [
"info": Array [
"CREATE new React Native module with the following options:

name: alice-bobbi
full package name: react-native-alice-bobbi
is view: false
object class name: AliceBobbi
Android nativePackageId: com.reactlibrary
platforms: android,ios
Apple tvosEnabled: false
authorName: Your Name
authorEmail: yourname@email.com
author githubAccount: github_account
license: MIT
useAppleNetworking: false
name: alice-bobbi
full package name: react-native-alice-bobbi
is view: false
object class name: AliceBobbi
Android nativePackageId: com.reactlibrary
platforms: android,ios
Apple tvosEnabled: false
authorName: Your Name
authorEmail: yourname@email.com
author githubAccount: github_account
license: MIT
useAppleNetworking: false
",
],
},
Expand Down
36 changes: 18 additions & 18 deletions ...ith-example/with-logging/__snapshots__/cli-program-with-example-with-logging.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,24 +206,24 @@ Array [
"info": Array [
"CREATE new React Native module with the following options:

name: test-package
full package name: react-native-test-package
is view: false
object class name: TestPackage
Android nativePackageId: com.reactlibrary
platforms: android,ios
Apple tvosEnabled: false
authorName: Your Name
authorEmail: yourname@email.com
author githubAccount: github_account
license: MIT
useAppleNetworking: false

generateExample: true
exampleFileLinkage: false
exampleName: example
exampleReactNativeTemplate: react-native@latest
writeExamplePodfile: false
name: test-package
full package name: react-native-test-package
is view: false
object class name: TestPackage
Android nativePackageId: com.reactlibrary
platforms: android,ios
Apple tvosEnabled: false
authorName: Your Name
authorEmail: yourname@email.com
author githubAccount: github_account
license: MIT
useAppleNetworking: false

generateExample: true
exampleFileLinkage: false
exampleName: example
exampleReactNativeTemplate: react-native@latest
writeExamplePodfile: false
",
],
},
Expand Down
36 changes: 18 additions & 18 deletions ...e/with-logging/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,24 +12,24 @@ Array [
"info": Array [
"CREATE new React Native module with the following options:

name: alice-bobbi
full package name: react-native-alice-bobbi
is view: false
object class name: AliceBobbi
Android nativePackageId: com.reactlibrary
platforms: android,ios
Apple tvosEnabled: false
authorName: Your Name
authorEmail: yourname@email.com
author githubAccount: github_account
license: MIT
useAppleNetworking: false

generateExample: true
exampleFileLinkage: false
exampleName: example
exampleReactNativeTemplate: react-native@latest
writeExamplePodfile: false
name: alice-bobbi
full package name: react-native-alice-bobbi
is view: false
object class name: AliceBobbi
Android nativePackageId: com.reactlibrary
platforms: android,ios
Apple tvosEnabled: false
authorName: Your Name
authorEmail: yourname@email.com
author githubAccount: github_account
license: MIT
useAppleNetworking: false

generateExample: true
exampleFileLinkage: false
exampleName: example
exampleReactNativeTemplate: react-native@latest
writeExamplePodfile: false
",
],
},
Expand Down
36 changes: 18 additions & 18 deletions ...e/with-example/with-logging/with-error/__snapshots__/with-yarn-error-logging.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,24 +12,24 @@ Array [
"info": Array [
"CREATE new React Native module with the following options:

name: alice-bobbi
full package name: react-native-alice-bobbi
is view: false
object class name: AliceBobbi
Android nativePackageId: com.reactlibrary
platforms: android,ios
Apple tvosEnabled: false
authorName: Your Name
authorEmail: yourname@email.com
author githubAccount: github_account
license: MIT
useAppleNetworking: false

generateExample: true
exampleFileLinkage: false
exampleName: example
exampleReactNativeTemplate: react-native@latest
writeExamplePodfile: false
name: alice-bobbi
full package name: react-native-alice-bobbi
is view: false
object class name: AliceBobbi
Android nativePackageId: com.reactlibrary
platforms: android,ios
Apple tvosEnabled: false
authorName: Your Name
authorEmail: yourname@email.com
author githubAccount: github_account
license: MIT
useAppleNetworking: false

generateExample: true
exampleFileLinkage: false
exampleName: example
exampleReactNativeTemplate: react-native@latest
writeExamplePodfile: false
",
],
},
Expand Down
36 changes: 18 additions & 18 deletions ...ple/with-logging/with-options/__snapshots__/create-with-example-with-options.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,24 +6,24 @@ Array [
"info": Array [
"CREATE new React Native module with the following options:

name: alice-bobbi
full package name: react-native-alice-bobbi
is view: false
object class name: AliceBobbi
Android nativePackageId: com.alicebits
platforms: android,ios
Apple tvosEnabled: true
authorName: Alice
authorEmail: contact@alice.me
author githubAccount: alicebits
license: ISC
useAppleNetworking: false

generateExample: true
exampleFileLinkage: true
exampleName: demo
exampleReactNativeTemplate: react-native@npm:react-native-tvos
writeExamplePodfile: false
name: alice-bobbi
full package name: react-native-alice-bobbi
is view: false
object class name: AliceBobbi
Android nativePackageId: com.alicebits
platforms: android,ios
Apple tvosEnabled: true
authorName: Alice
authorEmail: contact@alice.me
author githubAccount: alicebits
license: ISC
useAppleNetworking: false

generateExample: true
exampleFileLinkage: true
exampleName: demo
exampleReactNativeTemplate: react-native@npm:react-native-tvos
writeExamplePodfile: false
",
],
},
Expand Down